Updated vehicle and propulsion types and max speed #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain pull request
Per discussions on #692, aligned both vehicle and propulsion types to match GBFS vehicle types.
Added a
maximum_speedfield to the vehicle object.Is this a breaking change
Impacted Spec
Which spec(s) will this pull request impact?
agencypolicyproviderAdditional context
Now
propulsion_typesis aligned to GBFS values, including the definitions and the inclusion of hybrid. Though still with MDS multiple propulsion_types can be enumerated per vehicle.form_factoris aligned, but some new values had to be added like bus, delivery robot, truck, and motorcycle to support new modes. So now MDS includes everything in GBFS, plus new options.