Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI work for MDS #832

Merged
merged 13 commits into from
May 2, 2023
Merged

OpenAPI work for MDS #832

merged 13 commits into from
May 2, 2023

Conversation

schnuerle
Copy link
Member

@schnuerle schnuerle commented Feb 7, 2023

Explain pull request

Removing JSON Schema from MDS repository and instead moving to OpenAPI in a new external repository, mds-openapi.

Is this a breaking change

  • Yes, breaking

Impacted Spec

Which spec(s) will this pull request impact?

  • All

Additional context

To see the most recent development changes to the JSON Schema while the community was working on MDS 2.0, see the snapshot-jsonschema feature branch.

@schnuerle schnuerle requested a review from a team as a code owner February 7, 2023 02:42
@schnuerle schnuerle linked an issue Feb 7, 2023 that may be closed by this pull request
@schnuerle schnuerle added this to the 2.0.0 milestone Feb 7, 2023
@schnuerle schnuerle added the Schema Implications for JSON Schema or OpenAPI label Feb 7, 2023
@schnuerle
Copy link
Member Author

Note for this work, references to JSON Schema within each API page will need to be updated with direct links, including general schema references and per endpoint.

@schnuerle schnuerle linked an issue Feb 8, 2023 that may be closed by this pull request
@schnuerle schnuerle changed the base branch from dev to release-2.0.0 April 21, 2023 01:07
@schnuerle schnuerle requested a review from thekaveman April 21, 2023 01:07
@schnuerle
Copy link
Member Author

schnuerle commented Apr 21, 2023

Note to remove in page references to JSON Schema and update to OpenAPI, fix vehicle data type like on Provider page, add some mention of validation on the MDS home page in a new section, remove paratransit from robots.

README.md Outdated Show resolved Hide resolved
schema/README.md Outdated Show resolved Hide resolved
@thekaveman thekaveman mentioned this pull request Apr 26, 2023
@schnuerle
Copy link
Member Author

Merging this now so finalization work can focus on the touch-ups in the release-2.0.0 branch to avoid overlapping conflicts with the feature-openapi branch. This PR looks great for a first pass at moving to OpenAPI for MDS validation.

@schnuerle schnuerle merged commit 82c3e0e into release-2.0.0 May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Schema Implications for JSON Schema or OpenAPI
Projects
None yet
2 participants