Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding links to events and vehicles schema files #490

Merged
merged 1 commit into from
May 8, 2020

Conversation

thekaveman
Copy link
Collaborator

MDS Pull Request

Thank you for your contribution!

For most Pull Requests, the target branch should be dev. Please ensure you are targeting dev to avoid complications and help make the Review process as smooth as possible.

Explain pull request

(Late Addition to the RC!)

We link to the trips and status_changes schemas in this section, adding links to the events and vehicles schemas as well.

Is this a breaking change

  • No, not breaking

Impacted Spec

Which spec(s) will this pull request impact?

  • provider

@thekaveman thekaveman added Provider Specific to the Provider API Schema Implications for JSON Schema or OpenAPI documentation documentation change can be for code and/or markdown pages labels May 8, 2020
@thekaveman thekaveman added this to the 0.4.1 milestone May 8, 2020
@thekaveman thekaveman requested a review from a team as a code owner May 8, 2020 01:06
@thekaveman thekaveman requested a review from a team May 8, 2020 01:06
Copy link
Member

@schnuerle schnuerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for the catch Kegan.

@schnuerle schnuerle merged commit 48aa530 into release-0.4.1 May 8, 2020
@thekaveman thekaveman deleted the schema-links branch May 15, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation change can be for code and/or markdown pages Provider Specific to the Provider API Schema Implications for JSON Schema or OpenAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants