Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Data Definitions and Common Standards #325

Closed
wants to merge 1 commit into from
Closed

Create Data Definitions and Common Standards #325

wants to merge 1 commit into from

Conversation

whereissean
Copy link
Contributor

@whereissean whereissean commented May 31, 2019

Document a common set of data definitions and standards between MDS components.

Explain pull request

Please provide a clear and concise reason for this pull request and the impact of the change

Is this a breaking change

A breaking change would require consumers or implementors of the API to modify their code for it to continue to function (ex: renaming of a required field or the change in data type of an existing field). A non-breaking change would allow existing code to continue to function (ex: addition of an optional field or the creation of a new optional endpoint).

  • Yes, breaking
  • No, not breaking
  • I'm not sure

Provider or agency

Which API(s) will this pull request impact:

  • provider
  • agency
  • both

Additional context

Add any other context or screenshots about the feature request here.

Document a common set of data definitions between MDS components.
@whereissean whereissean requested review from hunterowens, thekaveman and a team as code owners May 31, 2019 21:57
@hunterowens hunterowens added this to the 0.4.0 milestone Jun 28, 2019
@hunterowens
Copy link
Collaborator

given that all the data definitions are being made in the schema directory, and are concated together by generate_schema.py, I think we shouldn't have a 2nd or 3rd place for information to live as a source of truth.

Ideally, I think we need to implement #281 to get to full data definitions.

@hunterowens
Copy link
Collaborator

closing for now but happy to reconsider this approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants