Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDS 2.0 - telemetry fields trip_ids/journey_id should correspond to the event #859

Closed
lastalfriday opened this issue May 2, 2023 · 2 comments

Comments

@lastalfriday
Copy link

lastalfriday commented May 2, 2023

Extracted from another issue here

EDIT
I'm a bit confused. I just noticed that there are some differences between the tag 2.0.0-rc1 and the branch release-2.0.0. So I'm splitting this issue into 1 and 2, as they are related (instead of making another issue)

1 - Which is right

https://github.com/openmobilityfoundation/mobility-data-specification/blob/release-2.0.0/data-types.md#events
(I'm guessing this is right, but why was journey_id removed? If it's relevant for telemetry, is it not relevant for events?)

image

https://github.com/openmobilityfoundation/mobility-data-specification/blob/2.0.0-rc1/data-types.md#events

image

2 - Telemetry fields that should be optional

The fields trip_ids and journey_id should be the same for telemetry and events, and I do believe events has it correct (these fields must be required if available and optional)

This diff/error is probably a cut n paste error?

image

@marie-x
Copy link
Collaborator

marie-x commented May 2, 2023

Good catch! Yes, they should be consistent. I think the wording in Telemetry conveys the intent better.

@thekaveman
Copy link
Collaborator

@lastalfriday The branch release-2.0.0 should be the base for any issues/review for MDS 2.0 as it is being updated continuously until the release.

The tag 2.0.0-rc1 was made back in Feb as part of the MDS Release Process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants