Fix if-enum statement #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @schnuerle @thekaveman |
thekaveman
reviewed
Mar 1, 2024
There was a problem hiding this comment.
I'm not sure this is a correct change:
event_types is an array with multiple different allowed values per mode and per vehicle_state.
enum restricts the value to a single option within the listed options.
contains restricts an array to contain one or more of the listed options.
mihailpw
force-pushed
the
feature/fix-if-enum
branch
from
0e9b55d to
e5be0c4
Compare
|
@thekaveman thanks for your review. I agree with you and fixed my code. Please take a look again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like there are bugs in if statement
Demo: https://jsonschema.dev/s/ohogp