-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java bindings: add BaseDataLoader, fixes and quirks for OffscreenMapRenderer #688
base: develop
Are you sure you want to change the base?
Conversation
Add abstract BaseDataLoader to share the common logic for DataLoaders in Java and use this in the HttpDataLoader. Remove the LocalDataLoader as it's never been used and seems redundant with the LocalDataProvider-option on the Tiled2dMapVectorLayerBuilder. With the BaseDataLoader, loading from resources can be easily added in project-specific subclasses. Extend the "quirks" (draw the frame repeatedly) to make the OffscreenMapRenderer work reliably again after rebasing these java bindings.
Initialize texture with premultiplied alpha, as expected by shader.
…w triggering manually
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Add abstract BaseDataLoader to share the common logic for DataLoaders in Java and use this in the HttpDataLoader.
Remove the LocalDataLoader as it's never been used and seems redundant with the LocalDataProvider-option on the Tiled2dMapVectorLayerBuilder. With the BaseDataLoader, loading from resources can be easily added in
project-specific subclasses.
Extend the "quirks" (draw the frame repeatedly) to make the OffscreenMapRenderer work reliably again after rebasing these java bindings.
Premultiply Alpha in BufferedImageTextureHolder. Initialize texture with premultiplied alpha, as expected by shader.
github workflow: allow building & deploying the java library on untagged versions, to allow optionally pushing binary builds to the maven repository from feature branches etc. This workflow can be triggered from the github UI, but only once this is merged into the default branch of the repository (see
workflow_dispatch
).