Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scikit_safe inference time measurement files #537

Merged
merged 2 commits into from
Jun 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions amlb/datasets/openml.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@
from typing import Generic, Tuple, TypeVar

import arff
import pandas as pd
import pandas.api.types as pat
import openml as oml
import xmltodict

from ..data import AM, DF, Dataset, DatasetType, Datasplit, Feature
from ..datautils import impute_array
from ..resources import config as rconfig, get as rget
from ..utils import as_list, lazy_property, path_from_split, profile, split_path, unsparsify

Expand Down Expand Up @@ -93,32 +95,52 @@ def test(self):
self._ensure_split_created()
return self._test

def inference_subsample_files(self, fmt: str, with_labels: bool = False) -> list[Tuple[int, str]]:
def inference_subsample_files(self, fmt: str, with_labels: bool = False, scikit_safe: bool = False) -> list[Tuple[int, str]]:
"""Generates n subsamples of size k from the test dataset in `fmt` data format.

We measure the inference time of the models for various batch sizes
(number of rows). We generate config.inference_time_measurements.repeats
subsamples for each of the config.inference_time_measurements.batch_sizes.

These subsamples are stored to file in the `fmt` format (parquet, arff, or csv).
The function returns a list of tuples of (batch size, file path).

Iff `with_labels` is true, the target column will be included in the split file.
Iff `scikit_safe` is true, categorical values are encoded and missing values
are imputed.
"""
seed = rget().seed(self.fold)
return [
(n, str(self._inference_subsample(fmt=fmt, n=n, seed=seed + i, with_labels=with_labels)))
(n, str(self._inference_subsample(fmt=fmt, n=n, seed=seed + i, with_labels=with_labels, scikit_safe=scikit_safe)))
for n in rconfig().inference_time_measurements.batch_sizes
for i, _ in enumerate(range(rconfig().inference_time_measurements.repeats))
]

@profile(logger=log)
def _inference_subsample(self, fmt: str, n: int, seed: int = 0, with_labels: bool = False) -> pathlib.Path:
""" Write subset of `n` samples from the test split to disk in `fmt` format """
def _inference_subsample(self, fmt: str, n: int, seed: int = 0, with_labels: bool = False, scikit_safe: bool = False) -> pathlib.Path:
""" Write subset of `n` samples from the test split to disk in `fmt` format

Iff `with_labels` is true, the target column will be included in the split file.
Iff `scikit_safe` is true, categorical values are encoded and missing values
are imputed.
"""
# Just a hack for now, the splitters all work specifically with openml tasks.
# The important thing is that we split to disk and can load it later.

# We should consider taking a stratified sample if n is large enough,
# inference time might differ based on class
test = self._test.data if with_labels else self._test.X
subsample = test.sample(
if scikit_safe:
if with_labels:
_, data = impute_array(self.train.data_enc, self.test.data_enc)
else:
_, data = impute_array(self.train.X_enc, self.test.X_enc)

columns = self._test.data.columns if with_labels else self._test.X.columns
data = pd.DataFrame(data, columns=columns)
else:
data = self._test.data if with_labels else self._test.X

subsample = data.sample(
n=n,
replace=True,
random_state=seed,
Expand Down
3 changes: 2 additions & 1 deletion frameworks/AutoGluon/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ def run_autogluon_tabular(dataset: Dataset, config: TaskConfig):
classes=dataset.target.values
),
problem_type=dataset.type.name, # AutoGluon problem_type is using same names as amlb.data.DatasetType
inference_subsample_files=dataset.inference_subsample_files(fmt="parquet"),
)
if config.measure_inference_time:
data["inference_subsample_files"] = dataset.inference_subsample_files(fmt="parquet")

return run_in_venv(__file__, "exec.py",
input_data=data, dataset=dataset, config=config)
Expand Down
3 changes: 2 additions & 1 deletion frameworks/GAMA/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ def run(dataset: Dataset, config: TaskConfig):
X=dataset.test.X,
y=dataset.test.y
),
inference_subsample_files=dataset.inference_subsample_files(fmt="parquet"),
)
if config.measure_inference_time:
data["inference_subsample_files"] = dataset.inference_subsample_files(fmt="parquet")
options = dict(
serialization=dict(sparse_dataframe_deserialized_format='dense')
)
Expand Down
3 changes: 2 additions & 1 deletion frameworks/H2OAutoML/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ def run(dataset: Dataset, config: TaskConfig):
target=dict(index=dataset.target.index),
domains=dict(cardinalities=[0 if f.values is None else len(f.values) for f in dataset.features]),
format=dataset.train.format,
inference_subsample_files=dataset.inference_subsample_files(fmt=dataset.train.format, with_labels=True),
)
if config.measure_inference_time:
data["inference_subsample_files"] = dataset.inference_subsample_files(fmt=dataset.train.format, with_labels=True)
config.ext.monitoring = rconfig().monitoring
return run_in_venv(__file__, "exec.py",
input_data=data, dataset=dataset, config=config)
Expand Down
3 changes: 2 additions & 1 deletion frameworks/RandomForest/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ def run(dataset: Dataset, config: TaskConfig):
X=X_test,
y=y_test
),
inference_subsample_files=dataset.inference_subsample_files(fmt="parquet"),
)
if config.measure_inference_time:
data["inference_subsample_files"] = dataset.inference_subsample_files(fmt="parquet", scikit_safe=True)

return run_in_venv(__file__, "exec.py",
input_data=data, dataset=dataset, config=config)
Expand Down
3 changes: 2 additions & 1 deletion frameworks/TPOT/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ def run(dataset: Dataset, config: TaskConfig):
X=X_test,
y=y_test
),
inference_subsample_files=dataset.inference_subsample_files(fmt="parquet"),
)
if config.measure_inference_time:
data["inference_subsample_files"] = dataset.inference_subsample_files(fmt="parquet")

def process_results(results):
if isinstance(results.probabilities, str) and results.probabilities == "predictions":
Expand Down
3 changes: 2 additions & 1 deletion frameworks/TunedRandomForest/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ def run(dataset: Dataset, config: TaskConfig):
X=X_test,
y=y_test
),
inference_subsample_files=dataset.inference_subsample_files(fmt="parquet"),
)
if config.measure_inference_time:
data["inference_subsample_files"] = dataset.inference_subsample_files(fmt="parquet", scikit_safe=True)

return run_in_venv(__file__, "exec.py",
input_data=data, dataset=dataset, config=config)
Expand Down
3 changes: 2 additions & 1 deletion frameworks/autosklearn/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ def run(dataset: Dataset, config: TaskConfig):
y_enc=unsparsify(dataset.test.y_enc),
),
predictors_type=['Numerical' if p.is_numerical() else 'Categorical' for p in dataset.predictors],
inference_subsample_files=dataset.inference_subsample_files(fmt="parquet"),
)
if config.measure_inference_time:
data["inference_subsample_files"] = dataset.inference_subsample_files(fmt="parquet")

return run_in_venv(__file__, "exec.py",
input_data=data, dataset=dataset, config=config)
Expand Down
3 changes: 2 additions & 1 deletion frameworks/flaml/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@ def run(dataset, config):
y=dataset.test.y
),
problem_type=dataset.type.name,
inference_subsample_files=dataset.inference_subsample_files(fmt="parquet"),
)
if config.measure_inference_time:
data["inference_subsample_files"] = dataset.inference_subsample_files(fmt="parquet")
options = dict(
serialization=dict(sparse_dataframe_deserialized_format='dense')
)
Expand Down
3 changes: 2 additions & 1 deletion frameworks/lightautoml/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ def run(dataset: Dataset, config: TaskConfig):
name=dataset.target.name,
),
problem_type=dataset.type.name,
inference_subsample_files=dataset.inference_subsample_files(fmt="parquet"),
)
if config.measure_inference_time:
data["inference_subsample_files"] = dataset.inference_subsample_files(fmt="parquet")
options = dict(
serialization=dict(sparse_dataframe_deserialized_format='dense')
)
Expand Down
3 changes: 2 additions & 1 deletion frameworks/mljarsupervised/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ def run(dataset: Dataset, config: TaskConfig):
y=dataset.test.y
),
problem_type=dataset.type.name,
inference_subsample_files=dataset.inference_subsample_files(fmt="parquet"),
)
if config.measure_inference_time:
data["inference_subsample_files"] = dataset.inference_subsample_files(fmt="parquet")
options = dict(
serialization=dict(sparse_dataframe_deserialized_format='dense')
)
Expand Down