Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newer autosklearn versions to use the pandas data instead #534

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

PGijsbers
Copy link
Collaborator

Use pandas dataframes with autosklearn>=0.15, instead of the encoded numpy arrays.
This is preferred because it is more "auto" and because it makes inference time measurements more comparable across frameworks.

note: this is on top of the measure_inference_time PR #532.

@eddiebergman @mfeurer are there any other changes that should be made to account for the switch?

@PGijsbers PGijsbers requested a review from mfeurer June 14, 2023 11:53
Copy link
Collaborator

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however probably better to have approval by @mfeurer first.

@PGijsbers PGijsbers merged commit 6c9ccb3 into measure_inference_time Jun 16, 2023
@PGijsbers PGijsbers deleted the autosklearn_on_pandas branch June 16, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants