Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measure inference time #532
Measure inference time #532
Changes from 19 commits
71e7a8b
87f80aa
94ba496
0c7bf7d
df46e1b
0621ee2
1a72ae1
7100391
f76e755
bf8cbc7
cb04989
8ea9033
338fc94
9b024e2
7b3455f
5733223
25a1bd4
a6f7a52
94f11f6
4119d56
0000c63
1d2054a
357a63f
2dd1ffc
1e5a61d
b48c5ed
42d38ac
4a38f6c
6c9ccb3
b24c12c
d5da2bd
cdb0828
4c14dbe
acae403
8caf629
f0cbfc0
b2c9b38
7a3f433
54a2dd6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were going to include the file loading as part of the predict time? Or is this not the case?
Current code would not include loading time as part of the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does for
measure_inference_times
, I'll make sure it does forpredict
too, where possible. thanks!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: in v0.8, we now have a cleaner way to do this: https://auto.gluon.ai/dev/api/autogluon.tabular.TabularPredictor.get_pred_from_proba.html
We can probably keep as is for now. Switching will only matter if we end up running on metrics where decision threshold calibration matters (balanced accuracy, f1, etc.), as the current code in AMLB is forcibly using decision_threshold=0.5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't use those metrics for our next set of experiments, but PR to make things also work for
0.8
is welcome.