Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating devtools, removing dashboard #192

Merged
merged 12 commits into from
Apr 29, 2023
Merged

Updating devtools, removing dashboard #192

merged 12 commits into from
Apr 29, 2023

Conversation

PGijsbers
Copy link
Member

@PGijsbers PGijsbers commented Apr 9, 2023

Doing some maintenance work here.
Originally I intended to just update devtools, but the outdated dependencies of the Dashboard made it more cumbersome than needed, so I decided to finally pull the trigger and remove the dashboard altogether. Removing the Dashboard had been something I had been planning to do for longer. Separating the dashboard into its own project makes it easier to separate dependencies between the two if their only interface is the log file. Originally I wanted to extract the Dashboard code, but since then enough time has passed that the Dashboard should be more-or-less built from the ground up anyway (and the git history remains available, of course).

As for the devtools, I'm currently figuring out what exactly I want but:

  • I am bumping dependencies of the ones that are currently in use
  • I am changing from flake8 to ruff

Also made a few changes to make tests green. Seems like an appropriate time to go for a merge before continuing to further update the devtool stack.

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

Thank you for the pull request! 🙏
If CI reports any errors please address them.
If you believe the errors are unrelated to your PR, please state why.
This will make it easier for the maintainers to assess your PR :)

@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #192 (c0c7ea2) into master (9596bf0) will increase coverage by 20.87%.
The diff coverage is 73.33%.

@@             Coverage Diff             @@
##           master     #192       +/-   ##
===========================================
+ Coverage   68.26%   89.13%   +20.87%     
===========================================
  Files          45       45               
  Lines        2187     2191        +4     
===========================================
+ Hits         1493     1953      +460     
+ Misses        694      238      -456     
Flag Coverage Δ
unit-tests 89.13% <73.33%> (+20.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gama/configuration/regression.py 100.00% <ø> (ø)
gama/genetic_programming/mutation.py 95.16% <ø> (+3.22%) ⬆️
gama/postprocessing/best_fit.py 80.00% <ø> (ø)
gama/utilities/evaluation_library.py 89.68% <ø> (+7.14%) ⬆️
gama/utilities/generic/async_evaluator.py 68.30% <0.00%> (+51.27%) ⬆️
gama/gama.py 84.77% <33.33%> (+30.19%) ⬆️
gama/genetic_programming/compilers/scikitlearn.py 77.01% <100.00%> (ø)
gama/genetic_programming/components/terminal.py 100.00% <100.00%> (ø)
gama/genetic_programming/operations.py 100.00% <100.00%> (ø)
gama/genetic_programming/selection.py 100.00% <100.00%> (+4.34%) ⬆️
... and 5 more

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Because some pixels were inferred as categorical.
See also #193
@github-actions
Copy link

Thank you for the pull request! 🙏
If CI reports any errors please address them.
If you believe the errors are unrelated to your PR, please state why.
This will make it easier for the maintainers to assess your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant