-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Scikit-Build-Core Support #3339
Open
ahnaf-tahmid-chowdhury
wants to merge
124
commits into
openmc-dev:develop
Choose a base branch
from
ahnaf-tahmid-chowdhury:skbuild-minimal
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enable Scikit-Build-Core Support #3339
ahnaf-tahmid-chowdhury
wants to merge
124
commits into
openmc-dev:develop
from
ahnaf-tahmid-chowdhury:skbuild-minimal
+404
−200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into scikit_build_core_wheel
…into scikit_build_core_wheel
Co-authored-by: Jon Shimwell <jon@proximafusion.com>
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
shimwell
reviewed
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for
scikit-build-core
, streamlining the build process and improving compatibility.Key Changes
Enable
scikit-build-core
supportpyproject.toml
to usescikit-build-core
instead of legacy methods.CMake and Build Updates
CMakeLists.txt
to supportskbuild
, ensuring compatibility with bothscikit-build-core
and native CMake builds.GenerateScript.cmake
to handle executable files (openmc
) on both Linux and macOS.OpenMCConfig.cmake.in
to integratescikit-build-core
.Git and Packaging Improvements
.h5
files from.gitignore
as they are needed.MANIFEST.in
as it is no longer required.CI and Docs Updates
pip install
asscikit-build-core
now handles it.Python API Enhancements
__init__.py
to retrieve OpenMC installation configuration from the Python side.