Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enhance Java snippets #276

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Fix and enhance Java snippets #276

merged 1 commit into from
Oct 13, 2022

Conversation

vargajb
Copy link
Contributor

@vargajb vargajb commented Oct 12, 2022

Signed-off-by: Janos Varga 113785741+vargajb@users.noreply.github.com

Proposed changes

The counter should start from 1 in the Java example 4 and 19, because the corresponding COBOL loop also starts from 1.
The commented out counter variable increment is fixed.
The commented out "write print-rec" is changed by System.out.println.

Fixes # (issue)

Type of change

What type of changes does your PR introduce to the COBOL Programming Course? Put an x in the boxes that apply.

  • Bug fix (change which fixes one or more issues)
  • New feature (change which adds functionality or features to the course)
  • Translations (change which adds or modifies translations of the course)
  • Documentation (change which modifies documentation related to the course)
  • This change requires an update to the course's z/OS environment

Checklist:

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the Contributing Guideline
  • I have included a title and description for this PR
  • I have DCO-signed all of my commits that are included in this PR
  • I have tested it manually and there are no regressions found
  • I have commented my code, particularly in hard-to-understand areas (if appropriate)
  • I have made corresponding changes to the documentation (if appropriate)

The counter should start from 1 in the Java example 4 and 19, because the corresponding COBOL loop also starts from 1.
The commented out counter variable increment is fixed.
The commented out "write print-rec" is changed by System.out.println.

Signed-off-by: Janos Varga <113785741+vargajb@users.noreply.github.com>
Copy link
Member

@tanto259 tanto259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tanto259 tanto259 merged commit 85e18a8 into openmainframeproject:master Oct 13, 2022
@tanto259 tanto259 added the enhancement New feature or request label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants