PHPMD updates (#5)

- closes #4
openmage-strict · Dec 10, 2023 · f2a3243 · f2a3243
1 parent d973d06
commit f2a3243
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 0 deletions.
diff --git a/src/app/code/core/Mage/AdminNotification/Helper/Data.php b/src/app/code/core/Mage/AdminNotification/Helper/Data.php
@@ -70,6 +70,9 @@ public function getUnreadNoticeCount($severity)
      * @param bool $withExt
      * @return string
      * @deprecated v19.4.16
+     *
+     * @SuppressWarnings(PHPMD.BooleanArgumentFlag)
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function getPopupObjectUrl($withExt = false)
     {

diff --git a/src/app/code/core/Mage/AdminNotification/Model/Inbox.php b/src/app/code/core/Mage/AdminNotification/Model/Inbox.php
@@ -113,6 +113,8 @@ public function parse(array $data)
      * @param string $url
      * @param bool $isInternal
      * @return $this
+     *
+     * @SuppressWarnings(PHPMD.BooleanArgumentFlag)
      */
     public function add($severity, $title, $description, $url = '', $isInternal = true)
     {
@@ -142,6 +144,8 @@ public function add($severity, $title, $description, $url = '', $isInternal = tr
      * @param string $url
      * @param bool $isInternal
      * @return $this
+     *
+     * @SuppressWarnings(PHPMD.BooleanArgumentFlag)
      */
     public function addCritical($title, $description, $url = '', $isInternal = true)
     {
@@ -157,6 +161,8 @@ public function addCritical($title, $description, $url = '', $isInternal = true)
      * @param string $url
      * @param bool $isInternal
      * @return $this
+     *
+     * @SuppressWarnings(PHPMD.BooleanArgumentFlag)
      */
     public function addMajor($title, $description, $url = '', $isInternal = true)
     {
@@ -172,6 +178,8 @@ public function addMajor($title, $description, $url = '', $isInternal = true)
      * @param string $url
      * @param bool $isInternal
      * @return $this
+     *
+     * @SuppressWarnings(PHPMD.BooleanArgumentFlag)
      */
     public function addMinor($title, $description, $url = '', $isInternal = true)
     {
@@ -187,6 +195,8 @@ public function addMinor($title, $description, $url = '', $isInternal = true)
      * @param string $url
      * @param bool $isInternal
      * @return $this
+     *
+     * @SuppressWarnings(PHPMD.BooleanArgumentFlag)
      */
     public function addNotice($title, $description, $url = '', $isInternal = true)
     {

diff --git a/src/app/code/core/Mage/AdminNotification/Model/Observer.php b/src/app/code/core/Mage/AdminNotification/Model/Observer.php
@@ -25,6 +25,8 @@ class Mage_AdminNotification_Model_Observer
      * Predispath admin action controller
      *
      * @param Varien_Event_Observer $observer
+     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function preDispatch(Varien_Event_Observer $observer)
     {

diff --git a/src/app/code/core/Mage/AdminNotification/Model/Resource/Inbox.php b/src/app/code/core/Mage/AdminNotification/Model/Resource/Inbox.php
@@ -61,6 +61,8 @@ public function loadLatestNotice(Mage_AdminNotification_Model_Inbox $object)
      *
      * @param Mage_AdminNotification_Model_Inbox $object
      * @return array
+     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function getNoticeStatus(Mage_AdminNotification_Model_Inbox $object)
     {
@@ -80,6 +82,8 @@ public function getNoticeStatus(Mage_AdminNotification_Model_Inbox $object)
      *
      * @param Mage_AdminNotification_Model_Inbox $object
      * @param array $data
+     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function parse(Mage_AdminNotification_Model_Inbox $object, array $data)
     {