Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple text document sync options #65

Merged
merged 4 commits into from
May 3, 2019
Merged

Multiple text document sync options #65

merged 4 commits into from
May 3, 2019

Conversation

danixeee
Copy link
Contributor

@danixeee danixeee commented Apr 16, 2019 •
edited by renatav
Loading

Description (e.g. "Related to ...", etc.)

Closes #57.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@danixeee danixeee added the enhancement New feature or request label Apr 16, 2019
@danixeee danixeee requested a review from augb April 16, 2019 11:59
@danixeee danixeee self-assigned this Apr 16, 2019
@danixeee danixeee force-pushed the danixeee/multiple-text-document-sync-options branch from 70d0be2 to e026322 Compare April 16, 2019 12:11
@augb augb removed their request for review April 16, 2019 14:02
@danixeee danixeee requested a review from renatav April 16, 2019 16:10
renatav
renatav previously approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@renatav renatav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renatav renatav merged commit 43759f6 into master May 3, 2019
@renatav renatav deleted the danixeee/multiple-text-document-sync-options branch May 3, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatav renatav renatav approved these changes

Assignees

@danixeee danixeee

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple text document synchronization options
2 participants
@danixeee @renatav