Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error or result field when sending JsonRPCResponseMessage #64

Merged
merged 3 commits into from
May 2, 2019
Merged

Remove error or result field when sending JsonRPCResponseMessage #64

merged 3 commits into from
May 2, 2019

Conversation

danixeee
Copy link
Contributor

@danixeee danixeee commented Apr 16, 2019 •
edited by renatav
Loading

Description (e.g. "Related to ...", etc.)

Closes #63.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@danixeee danixeee added the bug Something isn't working label Apr 16, 2019
@danixeee danixeee requested a review from augb April 16, 2019 09:10
@danixeee danixeee self-assigned this Apr 16, 2019
@danixeee danixeee force-pushed the danixeee/fix-response-object branch from 758c8a7 to c9dbf09 Compare April 16, 2019 09:32
@augb augb removed their request for review April 16, 2019 14:02
@renatav renatav self-requested a review May 2, 2019 16:47
@renatav renatav merged commit f830a37 into master May 2, 2019
@danixeee danixeee deleted the danixeee/fix-response-object branch May 13, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatav renatav renatav approved these changes

Assignees

@danixeee danixeee

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response object should contain result OR error field
2 participants
@danixeee @renatav