Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'ConfigurationParams' object has no attribute 'partial_result_token errors #310

Merged
merged 4 commits into from
Jan 3, 2023
Merged

Fix 'ConfigurationParams' object has no attribute 'partial_result_token errors #310

merged 4 commits into from
Jan 3, 2023

Conversation

alcarney
Copy link
Collaborator

@alcarney alcarney commented Jan 3, 2023 •
edited by tombh
Loading

Description (e.g. "Related to ...", etc.)

It turns out the workspace/configuration request requires a WorkspaceConfigurationParams object, rather than a plain ConfigurationParams object.

This PR

  • Fixes the AttributeErrors seen in the various get_configuration_xxx commands in the example json extension, as well as adding test cases to cover them going forward.
  • Fixes the type annotations in the various get_configuration_xxx methods in the pygls codebase
  • Updates the documentation to match

Fixes #307

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • [/] Docstrings have been included and/or updated, as appropriate
  • [/] Standalone docs have been updated accordingly
  • [/] CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@alcarney
json-extension: Fix AttributeError
c57abaa 
- The ``workspace/configuration`` method requires a
  ``WorkspaceConfigurationParams`` object.
- Add test cases to cover the various get_configuration methods
@alcarney
pygls: Fix get_configuration type annotations
34335c4
@alcarney
docs: Fix get_configuration examples
9595e5f
@alcarney
Update changelog
1ec1724
@alcarney alcarney requested a review from tombh January 3, 2023 23:48
@tombh
Copy link
Collaborator

tombh commented Jan 3, 2023

This looks ready to merge to me. Unless there's anything in particular you'd me to take a closer look at?

@alcarney
Copy link
Collaborator Author

alcarney commented Jan 3, 2023

Unless there's anything in particular you'd me to take a closer look at?

Not really, this one's pretty straightforward - we just missed a type in the lsprotocol migration

@tombh tombh merged commit b7e6e5c into openlawlibrary:master Jan 3, 2023
@tombh
Copy link
Collaborator

tombh commented Jan 3, 2023

Happy New Year 🎆😃

@alcarney
Copy link
Collaborator Author

alcarney commented Jan 3, 2023

Happy new year to you too! 😄

@alcarney alcarney deleted the fix-get-configuration branch January 3, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombh tombh tombh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError("'ConfigurationParams' object has no attribute 'partial_result_token'")
2 participants
@alcarney @tombh