-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: CoSApp: a Python library to create, simulate and design complex systems #6292
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
👋🏼 @elac-safran @jbussemaker & @chenxinye this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention the URL We aim for reviews to be completed within about 2-4 weeks (with a maximum of around 6 weeks). Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@HaoZeke) if you have any questions/concerns. Additional notesSince this is for Gitlab repo, links will not be automatically created from this issue, so I'd like to request @jbussemaker & @chenxinye to leave a summary comment when your review is complete with the issues opened. @elac-safran it might be useful to have a JOSS-Review label for issues related to the review in the repository. |
Review checklist for @chenxinyeConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @jbussemakerConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@jbussemaker, @chenxinye, I have added the label |
@editorialbot commands |
Hello @chenxinye, here are the things you can ask me to do:
|
@editorialbot check references |
|
@editorialbot check repository |
|
Wordcount for |
I've completed my review; the only remaining issues on my part are: the authors may upload their release in Zenodo and upload a plain text CITATION.cff file to the default branch of the repository. After that I have no further issues ;-) The software as well as the document and paper are well-written! I believe this is a novel software contribution to the community. |
Hello @HaoZeke. I have a few questions concerning the review process: What is the best practice, regarding the paper, if changes are made to the code per reviewer's request? |
Excellent question @elac-safran. Please feel free to continue development as usual. At the end of the review, after all the comments are in and acceptance is recommended, I will request a new tagged release and archive (e.g. on Zenodo, figshare, or others). After that, I'll set the archive to the same. |
@jbussemaker just checking in, has @elac-safran been able to address your concerns about the paper? I see there was a discussion on this issue? |
@HaoZeke they are work-in-progress as far as I know. Can you confirm @elac-safran ? |
@HaoZeke @jbussemaker I have been very busy at work in the past two weeks. I will submit a revised version of the manuscript as soon as possible. I apologize for the delay. |
@editorialbot check references |
@elac-safran - can you add a country for the QuantStack affiliation in your metadata? I've also suggested a few small changes in https://gitlab.com/cosapp/cosapp/-/merge_requests/277 - please merge this or let me know what you disagree with. |
I'm also concerned about the JATS compiled submission. I would prefer not to submit until I better understand the impact of this warning. |
I understand. I can try to find an alternative notation, but this is already standard LaTeX, so I figured it would be accepted as is. |
Let's just wait a little bit on this and see what I find out from the JOSS developer team. |
@elac-safran - another editor suggests
Can you try this? |
Yup, I can definitely try this. However, from my LaTeX years, I remember this syntax requires package |
@editorialbot generate pdf |
@danielskatz the newly generated pdf appears to be correct. Can you please re-run the checks on your end to confirm that everything is fine now? |
Yes, but can you also make the other changes if you haven't yet, so we can do all of this at once? (the PR and affiliation country from #6292 (comment)) |
Sorry, I missed that. I will make the changes right away. |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
@elac-safran - I think this looks fine (the proof). Do you agree? I'm also checking to make sure there are no warnings in the trail acceptance. |
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5077, then you can now move forward with accepting the submission by compiling again with the command |
Everything looks good to me. Thank you very much. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @elac-safran (Étienne Lac) and co-authors on your publication!! And thanks to @jbussemaker and @chenxinye for reviewing, and to @HaoZeke for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @elac-safran (Étienne Lac)
Repository: https://gitlab.com/cosapp/cosapp
Branch with paper.md (empty if default branch): joss-article
Version: v0.15.4
Editor: @HaoZeke
Reviewers: @jbussemaker, @chenxinye
Archive: 10.5281/zenodo.10722403
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@jbussemaker & @chenxinye, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @HaoZeke know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @chenxinye
📝 Checklist for @jbussemaker
The text was updated successfully, but these errors were encountered: