-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Chi: A Python package for treatment response modelling #5925
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Thanks! I somehow missed this. @ns-rse I'll add you as a reviewer, please let me know if you cannot review anymore. |
@editorialbot add @ns-rse as reviewer |
@ns-rse added to the reviewers list! |
@DavAug could you take a look at the missing DOIs flagged by editorial bot and fix them please? |
Of course! No problem 😊 |
Review checklist for @ns-rseConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf |
I fixed the Invalid DOI and manually checked the "Missing" ones. They all link to the correct publication on https://www.doi.org/ |
@editorialbot commands |
Hello @DavAug, here are the things you can ask me to do:
|
@editorialbot check references |
|
One of the articles that we are referencing just got published, so I am just replacing the reference to the preprint by the reference to the peer-reviewed publication. |
@editorialbot generate pdf |
@editorialbot check references |
|
|
|
Element isbn: [facet 'minLength'] The value has a length of '9'; this underruns the allowed minimum length of '10'. |
@Kevin-Mattheus-Moerman can you help with this error? I don't know what to make of this. |
@editorialbot generate pdf |
@editorialbot check references |
|
Hi @ppxasjsm @Kevin-Mattheus-Moerman Thank you so much for recommending the acceptance of my article. I really appreciate it! :) I just had a quick look into the error message, and while I am not sure why the error occured, I noticed that it was related to "wrong" ISBN in one of my BibTeX entries. Since the ISBN is not actually included in the reference that appear on the rendered article, I simply removed it. @ppxasjsm would you, perhaps, be able to trigger the acceptance again? I hope that this will remove the error (I saw that an article was successfully published yesterday, so the error does seem to be specific to my article). Thank you so much and best wishes, |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4979, then you can now move forward with accepting the submission by compiling again with the command |
Hi @Kevin-Mattheus-Moerman , thank you so much for recommending the acceptance. I just wanted to kindly confirm that accepting the submission is not in my mandate? I.e. we are not waiting for me to approve the final version of the article. Best, |
@DavAug As AEiC I will now help process this submission for acceptance in JOSS. I have just checked your repository, the archive link, this review, and the paper. Most seems in order. I do however have the below points that require your attention:
|
Hi @Kevin-Mattheus-Moerman , Thank you so much for the thorough review! Requested updates are now completed.
|
@editorialbot generate pdf |
@DavAug great, thanks, now all looks in order, ready to proceed. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@DavAug congrats on this publication with JOSS! Thanks for editing @ppxasjsm! And a special thank you to the reviewers: @shahmoradi, @ns-rse!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @DavAug (David Augustin)
Repository: https://github.com/DavAug/chi
Branch with paper.md (empty if default branch): joss-publication
Version: 1.0.0
Editor: @ppxasjsm
Reviewers: @shahmoradi, @ns-rse
Archive: 10.5281/zenodo.10510572
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@shahmoradi, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ppxasjsm know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @ns-rse
📝 Checklist for @shahmoradi
The text was updated successfully, but these errors were encountered: