-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: UnlockNN: Uncertainty quantification for neural network models of chemical systems #3700
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @TahiriNadia, @pmeier, @Het-Shah it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Wordcount for |
|
|
@TahiriNadia, @pmeier, @Het-Shah thanks for agreeing to review this submission. This is the review issue, andd you find your review checklist above. Please reach out to me if you have any questions. |
👋 @Het-Shah, please update us on how your review is going (this is an automated reminder). |
👋 @pmeier, please update us on how your review is going (this is an automated reminder). |
👋 @TahiriNadia, please update us on how your review is going (this is an automated reminder). |
@Het-Shah, could you please update us on how it is going with the review? If you have any suggestions for improvement of the software or the paper, feel free to post it here or to open an issue in the source repository. |
@pmeier, could you please update us on how it is going with the review? If you have any suggestions for improvement of the software or the paper, feel free to post it here or to open an issue in the source repository. |
@TahiriNadia, could you please update us on how it is going with the review? If you have any suggestions for improvement of the software or the paper, feel free to post it here or to open an issue in the source repository. |
@osorensen I've checked all the basic things and so far everything looks good. The paper is well written. The only thing left for me is to check its functionality and the documentation thereof. This might take some time, since I'm neither familiar with TensorFlow / keras nor have any domain knowledge. Regarding the latter, I fail to see how I should provide an opinion if the literature references are complete or not. |
Thanks for replying, @pmeier! Regarding the literature references, I assume you're referring to this part:
I suggest you can interpret this as asking whether papers/datasets/software mentioned inside the paper are properly cited, and whether the citation syntax is correct. So if you don't have an overview of this particular application area, you may still check off the box if the citations are done formally correct. |
Sorry, I started to revise the article this weekend, however, I can't do anything, no update! |
Sorry, @TahiriNadia, I didn't really understand. Is there a technical issue which means you cannot do anything? |
@whedon re-invite @TahiriNadia as reviewer |
The reviewer already has a pending invite. @TahiriNadia please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations |
If that doesn't work (as there's a weird bug that sometimes marks the invitation as expired late), let us know and we'll re-issue it - this should let you check the boxes... |
Thank you @whedon and @danielskatz. It's exactly my case. |
@whedon re-invite @TahiriNadia as reviewer |
OK, the reviewer has been re-invited. @TahiriNadia please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations |
|
Related to [JOSS submission](openjournals/joss-reviews#3700). I think this might be the correct reference for Tran et al. (2020)? If not, let's keep the arXiv reference as is.
Thanks @a-ws-m. Could you please check the latest PR I made in the source repository? |
Done, thanks for the correction! |
@editorialbot generate pdf |
@editorialbot check references |
|
@editorialbot recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3347, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot recommend-accept thanks, this looks ready to go |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3348, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept sorry, this is what I meant to do... |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @a-ws-m (Alexander Moriarty) and co-authors!! And thanks to @TahiriNadia, @pmeier, and @Het-Shah for reviewing, and to @osorensen for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you all for your time and feedback! Feels great to have this published :) |
Submitting author: @a-ws-m (Alexander Moriarty)
Repository: https://github.com/a-ws-m/unlockNN/
Branch with paper.md (empty if default branch):
Version: v2.0.2
Editor: @osorensen
Reviewers: @TahiriNadia, @pmeier, @Het-Shah
Archive: 10.5281/zenodo.6799685
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@TahiriNadia & @pmeier & @Het-Shah, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @TahiriNadia
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @pmeier
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @Het-Shah
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: