Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: AstronomicAL: an interactive dashboard for visualisation, integration and classification of data with Active Learning #3588

Closed
whedon opened this issue Aug 6, 2021 · 27 comments

Comments

@whedon
Copy link

whedon commented Aug 6, 2021

Submitting author: @grant-m-s (Grant Stevens)
Repository: https://github.com/grant-m-s/astronomicAL
Version: v1.0.0
Editor: @crvernon
Reviewers: @crhea93, @rmorgan10
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/2dc5147d2c434806e2c8b8126c132104"><img src="https://joss.theoj.org/papers/2dc5147d2c434806e2c8b8126c132104/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/2dc5147d2c434806e2c8b8126c132104/status.svg)](https://joss.theoj.org/papers/2dc5147d2c434806e2c8b8126c132104)

Author instructions

Thanks for submitting your paper to JOSS @grant-m-s. Currently, there isn't an JOSS editor assigned to your paper.

@grant-m-s if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Aug 6, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Aug 6, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.12 s (380.5 files/s, 99071.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          22           2341           1023           6664
reStructuredText                16            528            650            418
JSON                             3              0              0            290
Markdown                         1             20              0             32
Jupyter Notebook                 1              0            162             28
DOS Batch                        1              8              1             26
YAML                             2              3              5             18
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            47           2904           1848           7485
-------------------------------------------------------------------------------


Statistical information for the repository '01983bc8b4532cd31e66f079' was
gathered on 2021/08/06.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Grant Stevens                  226         16604           6576          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Grant Stevens             10028           60.4          3.4                2.76

@whedon
Copy link
Author

whedon commented Aug 6, 2021

PDF failed to compile for issue #3588 with the following error:

 Can't find any papers to compile :-(

@whedon whedon added the Python label Aug 6, 2021
@arfon
Copy link
Member

arfon commented Aug 6, 2021

@whedon generate pdf from branch joss-paper-branch

@whedon
Copy link
Author

whedon commented Aug 6, 2021

Attempting PDF compilation from custom branch joss-paper-branch. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 6, 2021

PDF failed to compile for issue #3588 with the following error:

 /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon/orcid_validator.rb:12:in `initialize': undefined method `strip' for nil:NilClass (NoMethodError)
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:155:in `new'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:155:in `block in check_orcids'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:153:in `each'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:153:in `check_orcids'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:90:in `initialize'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon/processor.rb:38:in `new'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon/processor.rb:38:in `set_paper'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/bin/whedon:58:in `prepare'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/bin/whedon:131:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `load'
	from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `<main>'

@grant-m-s
Copy link

@whedon generate pdf from branch joss-paper-branch

@whedon
Copy link
Author

whedon commented Aug 7, 2021

Attempting PDF compilation from custom branch joss-paper-branch. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 7, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@grant-m-s
Copy link

possible reviewers: smith42 crhea93 rmorgan10 arunmano121 a-slide

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Aug 9, 2021
@arfon
Copy link
Member

arfon commented Aug 9, 2021

@grant-m-s – thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@crvernon
Copy link

👋 @grant-m-s I'll be your editor for this submission. Thanks for recommending potential reviewers!

@crvernon
Copy link

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Aug 18, 2021

OK, the editor is @crvernon

@crvernon crvernon removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Aug 18, 2021
@crvernon
Copy link

👋 @rmorgan10 @crhea93 - Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@crhea93
Copy link

crhea93 commented Aug 18, 2021

@crvernon Yes please!

@crvernon
Copy link

Excellent @crhea93! I'll sign you up. Thank you!

@crvernon
Copy link

@whedon assign @crhea93 as reviewer

@whedon whedon assigned crhea93 and crvernon and unassigned crvernon Aug 18, 2021
@whedon
Copy link
Author

whedon commented Aug 18, 2021

OK, @crhea93 is now a reviewer

@crvernon
Copy link

👋 @Smith42 - Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@rmorgan10
Copy link

@crvernon Sorry for the delay! If the offer is still available, I would be happy to review AstronomicAL :)

@crvernon
Copy link

No problem @rmorgan10, the offer is still open and I'll assign you as a reviewer. Thanks!

@crvernon
Copy link

@whedon add @rmorgan10 as reviewer

@whedon whedon assigned crhea93, crvernon and rmorgan10 and unassigned crvernon and crhea93 Aug 20, 2021
@whedon
Copy link
Author

whedon commented Aug 20, 2021

OK, @rmorgan10 is now a reviewer

@crvernon
Copy link

Alright @rmorgan10 @crhea93 @grant-m-s I am going to close this Pre-Review and kick off the full review which you should receive a notification for. We aim for reviews to be completed within about 2-4 weeks. Thanks!

@crvernon
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Aug 20, 2021

OK, I've started the review over in #3635.

@whedon whedon closed this as completed Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants