Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: optimade-python-tools: a Python library for serving and consuming materials data via OPTIMADE APIs #3370

Closed
whedon opened this issue Jun 14, 2021 · 23 comments

Comments

@whedon
Copy link

whedon commented Jun 14, 2021

Submitting author: @ml-evs (Matthew L Evans)
Repository: https://github.com/Materials-Consortia/optimade-python-tools
Version: v0.15.3
Editor: @jgostick
Reviewers: @hungpham2017, @jamesrhester
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ef9a3b0e180c8668093a23b5a069c419"><img src="https://joss.theoj.org/papers/ef9a3b0e180c8668093a23b5a069c419/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ef9a3b0e180c8668093a23b5a069c419/status.svg)](https://joss.theoj.org/papers/ef9a3b0e180c8668093a23b5a069c419)

Author instructions

Thanks for submitting your paper to JOSS @ml-evs. Currently, there isn't an JOSS editor assigned to your paper.

@ml-evs if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jun 14, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 14, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.29 s (766.3 files/s, 131551.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                            18              0              0          17048
Python                         121           3552           3223          11576
Markdown                        64            461              0           1092
YAML                             9             89              6            496
SVG                              1              0              0            232
Bourne Shell                     5             25              5            217
HTML                             1              1              0             50
Dockerfile                       1              6              1             13
INI                              1              0              0             11
CSS                              1              1              0              8
-------------------------------------------------------------------------------
SUM:                           222           4135           3235          30743
-------------------------------------------------------------------------------


Statistical information for the repository 'd6baf135c76300b5c8c15c6c' was
gathered on 2021/06/14.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Abhijith Gopakumar               4           158             27            0.31
Adam Fekete                     37          1649            671            3.91
Andrius Merkys                   2             4              4            0.01
Casper Welzel Anders           245         15042           7936           38.68
Diether John Estrada             2            67             24            0.15
Donny Winston                   31          1487           2275            6.33
Fawzi Mohamed                    7           173             74            0.42
Kamal Choudhary                  1           112              2            0.19
Leopold Talirz                   6           558             44            1.01
Markus Scheidgen                 4           390              3            0.66
Matthew Evans                  300         14393           6303           34.84
Michael Wu                      44          3778           2085            9.87
OPTIMADE Developers             27            27             27            0.09
Shyam Dwaraknath                48           513            764            2.15
Thomas Purcell                  11           534            245            1.31
dependabot-preview[b             2             2              2            0.01
dependabot[bot]                  6            16             13            0.05

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Adam Fekete                 395           24.0         19.0                8.10
Andrius Merkys                3           75.0          8.7                0.00
Casper Welzel Anders       8015           53.3         12.6                7.41
Donny Winston               127            8.5         25.2                0.00
Fawzi Mohamed                 7            4.0         23.9                0.00
Kamal Choudhary              82           73.2         12.0               13.41
Leopold Talirz              119           21.3         23.1                1.68
Markus Scheidgen            112           28.7         17.5                2.68
Matthew Evans              9205           64.0          8.3                7.27
Michael Wu                    4            0.1         31.5                0.00
OPTIMADE Developers           1            3.7          0.0                0.00
Shyam Dwaraknath            183           35.7         13.0                1.09
Thomas Purcell               92           17.2         23.9                6.52
dependabot[bot]               6           37.5          2.1               16.67

@whedon
Copy link
Author

whedon commented Jun 14, 2021

PDF failed to compile for issue #3370 with the following error:

 Can't find any papers to compile :-(

@ml-evs
Copy link

ml-evs commented Jun 14, 2021

@whedon generate pdf from branch joss

@whedon
Copy link
Author

whedon commented Jun 14, 2021

Attempting PDF compilation from custom branch joss. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jun 14, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@ml-evs
Copy link

ml-evs commented Jun 14, 2021

Hello! Here are some potential reviewers with relevant backgrounds (~materials/crystallography/APIs) that I can see in the list:

  • bocklund
  • hungpham2017
  • mturiansky
  • marshallmcdonnell
  • janash
  • rosecers
  • jamesrhester

@danielskatz
Copy link

@whedon check references from branch joss

@whedon
Copy link
Author

whedon commented Jun 14, 2021

Attempting to check references... from custom branch joss

@whedon
Copy link
Author

whedon commented Jun 14, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.commatsci.2012.10.028 is OK
- 10.5281/zenodo.4195051 is OK
- 10.1088/1361-648x/aa680e is OK
- 10.1038/s41597-020-00638-4 is OK
- 10.1038/s41524-020-00440-1 is OK
- 10.1038/s41597-020-00637-5 is OK
- 10.1063/1.4812323 is OK
- 10.1038/s41524-017-0048-5 is OK
- 10.1016/j.commatsci.2014.10.037 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@danielskatz
Copy link

👋 @jgostick - would you be willing to edit this submission

@danielskatz
Copy link

@whedon invite @jgostick as editor

@whedon
Copy link
Author

whedon commented Jun 14, 2021

@jgostick has been invited to edit this submission.

@ml-evs
Copy link

ml-evs commented Jun 28, 2021

I know notifications are very easy to miss on GitHub, and I see that @jgostick has been active in other reviews, so I hope it is not rude if I bump this thread. My other editorial suggestion was Richard Gowers (richardgowers on GitHub).

@jgostick
Copy link

jgostick commented Jul 7, 2021

I am sorry, I am basically awash in github notifications. I don't even look at my github dashboard anymore. In fact, I only noticed this because I saw my avatar while browsing the "submissions without an editor" page.

@jgostick
Copy link

jgostick commented Jul 7, 2021

@whedon assign @jgostick as editor

@whedon
Copy link
Author

whedon commented Jul 7, 2021

OK, the editor is @jgostick

@jgostick
Copy link

jgostick commented Jul 7, 2021

@whedon add @hungpham2017 as reviewer

@whedon whedon assigned jgostick and unassigned jgostick Jul 7, 2021
@whedon
Copy link
Author

whedon commented Jul 7, 2021

OK, @hungpham2017 is now a reviewer

@jgostick
Copy link

jgostick commented Jul 7, 2021

@whedon add @jamesrhester as reviewer

@whedon
Copy link
Author

whedon commented Jul 7, 2021

OK, @jamesrhester is now a reviewer

@jgostick
Copy link

jgostick commented Jul 7, 2021

@whedon start review

@whedon
Copy link
Author

whedon commented Jul 7, 2021

OK, I've started the review over in #3458.

@whedon whedon closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants