Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: PulseqDiffusion: PyPulseq implementation of Diffusion-Weighted Echo Planar Imaging #2470

Closed
whedon opened this issue Jul 10, 2020 · 28 comments

Comments

@whedon
Copy link

whedon commented Jul 10, 2020

Submitting author: @ritagnunes (Rita G. Nunes)
Repository: https://github.com/ritagnunes/PulseqDiffusion
Version: v1.0.0
Editor: @Kevin-Mattheus-Moerman
Reviewers: @mathieuboudreau, @grlee77
Managing EiC: Kyle Niemeyer

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @ritagnunes. Currently, there isn't an JOSS editor assigned to your paper.

@ritagnunes if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jul 10, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 10, 2020

PDF failed to compile for issue #2470 with the following error:

Can't find any papers to compile :-(

@kyleniemeyer
Copy link

Hi @ritagnunes, it looks like the URL you included when submitting is incorrect. Can you fix this?

@ritagnunes
Copy link

The full URL should be: https://github.com/ritagnunes/PulseqDiffusion
Thanks

@kyleniemeyer
Copy link

@arfon can we tell whedon to update the repo URL to https://github.com/ritagnunes/PulseqDiffusion for checking and building the paper?

@kyleniemeyer
Copy link

I edited the metadata above manually, but I assume that doesn't change anything internally

@arfon
Copy link
Member

arfon commented Jul 10, 2020

@arfon can we tell whedon to update the repo URL to https://github.com/ritagnunes/PulseqDiffusion for checking and building the paper?

I've fixed this on the back end too. For now there's not a Whedon-way to do this.

@kyleniemeyer
Copy link

@whedon check repository

@whedon
Copy link
Author

whedon commented Jul 10, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.22 s (218.8 files/s, 22313.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
MATLAB                          24            271            399           1432
Python                          11            410            439           1357
Markdown                         6             72              0            214
TeX                              1             14              0            139
reStructuredText                 5             57             75             62
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            49            836            921           3239
-------------------------------------------------------------------------------


Statistical information for the repository '2470' was gathered on 2020/07/10.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Keerthi Sravan Ravi              4           478            368            7.26
PavanPoojar                      1           647              0            5.55
Rita G. Nunes                   17          3246           2821           52.08
opennog                         12          2636           1454           35.11

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Keerthi Sravan Ravi         352           73.6          0.1                0.00
Rita G. Nunes               794           24.5          1.0               17.51
opennog                    1060           40.2          1.2               17.74

@kyleniemeyer
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 10, 2020

@kyleniemeyer
Copy link

Hey @Kevin-Mattheus-Moerman, I know you've already got a lot on your plate, but this looks to be up your alley, and builds on a previous paper that you edited. Can you take this one on?

@kyleniemeyer
Copy link

@whedon invite @Kevin-Mattheus-Moerman as editor

@whedon
Copy link
Author

whedon commented Jul 10, 2020

@Kevin-Mattheus-Moerman has been invited to edit this submission.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Jul 12, 2020

OK, the editor is @Kevin-Mattheus-Moerman

@Kevin-Mattheus-Moerman
Copy link
Member

@grlee77, @mathieuboudreau, @spinicist thanks for your review efforts to date! Would you be interested in helping with this review? It is related to this work you reviewed for us: #1725
@mfroeling this also looks like your cup of tea, would you be interested in helping? Thanks!

Paper: https://github.com/openjournals/joss-papers/blob/joss.02470/joss.02470/10.21105.joss.02470.pdf
Software: https://github.com/ritagnunes/PulseqDiffusion

Also do let me know if I am overloading you with review requests.

@mathieuboudreau
Copy link

I can, but I'm only available in about a week as I'm currently on vacation.

@grlee77
Copy link

grlee77 commented Jul 12, 2020

yes, I am available

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @mathieuboudreau as reviewer

@whedon
Copy link
Author

whedon commented Jul 12, 2020

OK, @mathieuboudreau is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

I can, but I'm only available in about a week as I'm currently on vacation.

That is fine thank you so much!

@Kevin-Mattheus-Moerman
Copy link
Member

yes, I am available

Thanks!!

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon add @grlee77 as reviewer

@whedon
Copy link
Author

whedon commented Jul 12, 2020

OK, @grlee77 is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented Jul 12, 2020

OK, I've started the review over in #2478.

@whedon whedon closed this as completed Jul 12, 2020
@spinicist
Copy link

Hello,
I didn't get a chance to respond - as the others have kindly volunteered and I am very busy at the moment, I will decline this invitation. Thanks to @mathieuboudreau and @grlee77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants