-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: Simple-Web-Server: a fast and flexible HTTP/1.1 C++ client and server library #1579
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
|
@gkthiruvathukal - would you be willing to edit this submission? |
@danielskatz Yes, I will edit this one. |
@whedon assign @gkthiruvathukal as editor |
OK, the editor is @gkthiruvathukal |
@gkthiruvathukal - in case you didn't know, you can do this (assign yourself as editor) too... |
Thanks for letting me know! I will do that next time, @danielskatz. |
@danielskatz Any idea why this submission did not move to review state after you assigned me? On my dashboard, it shows as review_pending. Disregard: I need to take it from here! :) Sorry. |
@whedon commands |
Here are some things you can ask me to do:
|
@eidheim if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission. Thanks! |
@eidhelm Can you also comment on two things:
The first question is important from a JOSS standpoint. |
@gkthiruvathukal First of all, thank you for accepting to be editor for this submission.
I see there are several potential reviewers with C++ as one of their preferred programming languages. The ones that stood out to me as having relevant background was: gradvohl, aaronyd, hainesr, jaynanavati, nmullins, HaoZeke, Danbo3004, gcdeshpande and adi3.
Simple-Web-Server can be helpful for any research software written in C++ that needs to communicate with remote endpoints through HTTP or HTTPS. It is a general purpose library that might aid software development in several research fields. An example another paper accepted by JOSS describing a general purpose library can be found here: https://github.com/openjournals/joss-papers/blob/ceab2f713f640fcb4602a05206fbdbb8d04261a0/joss.01109/10.21105.joss.01109.pdf
Yes, Simple-Web-Server supports HTTPS. This is mentioned in the first paragraph of the summery in the paper: "Simple-Web-Server is a library that can be utilized in C++ applications to |
@eidheim Thanks for your responses. This is all I needed to proceed with assigning reviewers. I would like see a clear mention of how this helps research software (the language you provided being just about all we need) and to split HTTP and HTTPS. I even failed to notice the regex-like syntax at first. |
@gradvohl, @aaronyd, @hainesr, @jaynanavati, @nmullins, @HaoZeke, @Danbo3004, @gcdeshpande and @adi3: Would you be willing to contribute a review for this JOSS submission? I need two reviewers. I plan to assign on an FCFS basis. I know a couple of you have helped me on recent submissions but would be grateful to have your help again. |
@gkthiruvathukal I would be willing but there need to be significant rewrites. As far as I can tell there are no indications as to how this benefits researchers. It seems like a nice project though.. I understand it has been used for courses, but perhaps before being considered for publication here, perhaps enumerating which features or algorithms are implemented might be a start. Also of concern to me is the fact that most of the references are not part of academia (in terms of peer-reviewed journals) at all. |
@whedon check references |
|
|
OK, the reviewer is @HaoZeke |
Awaiting one more reviewer! |
@gkthiruvathukal, sure, thanks. I am certain that working with @eidheim will definitely make this a valued contribution. Will continue once the review starts. |
@gkthiruvathukal I can take this on. The library is probably useful and I think @eidheim will just need to elucidate his response more specifically
By the way, the code itself should have comments and documentation beyond a readme. This is especially important for a library where a doxygen-built API would help users. Not sure if that is part of the review process though. |
@ts-adi it will be. |
@ts-adi I'm grateful that you are willing to be a reviewer. Let me assign you and get the ball rolling. All of these comments will be helpful for the actual review. |
OK, the reviewer is @ts-adi |
@whedon start review |
OK, I've started the review over in #1592. Feel free to close this issue now! |
Happy to take up.. if still available
Thanks and Regards
Gajendra C. Deshpande
Assistant Professor, CSE@KLS.GIT
Belgaum - 590008
Karnataka, INDIA
Blog: http://gajendramoksha.wordpress.com
Website: http://sites.google.com/a/git.edu/gcd
Facebook: https://www.facebook.com/gcdeshpande
[http://csta.acm.org/Membership/sub/badge.jpg]
…________________________________
From: George K. Thiruvathukal <notifications@github.com>
Sent: Wednesday, July 24, 2019 8:54 PM
To: openjournals/joss-reviews <joss-reviews@noreply.github.com>
Cc: Gajendra Deshpande <gcdeshpande@hotmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: Simple-Web-Server: a fast and flexible HTTP/1.1 C++ client and server library (#1579)
@gradvohl<https://github.com/gradvohl>, @aaronyd<https://github.com/aaronyd>, @hainesr<https://github.com/hainesr>, @jaynanavati<https://github.com/jaynanavati>, @nmullins<https://github.com/nmullins>, @HaoZeke<https://github.com/HaoZeke>, @Danbo3004<https://github.com/Danbo3004>, @gcdeshpande<https://github.com/gcdeshpande> and @adi3<https://github.com/adi3>: Would you be willing to contribute a review for this JOSS submission? I need two reviewers. I plan to assign on an FCFS basis. I know a couple of you have helped me on recent submissions but would be grateful to have your help again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1579?email_source=notifications&email_token=AA4FHVLQRVEDNMN33DAIBFTQBBXZPA5CNFSM4IE6TVTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2WWDQQ#issuecomment-514679234>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA4FHVJQ7DS2YJDQIEPWSQTQBBXZPANCNFSM4IE6TVTA>.
|
@gcdeshpande I will keep you in mind for another submission. Thanks for responding! |
…(comment). Also added .markdown-format to autoformat paper.md on save
Submitting author: @eidheim (Ole Christian Eidheim)
Repository: https://gitlab.com/eidheim/Simple-Web-Server
Version: v3.0
Editor: @gkthiruvathukal
Reviewers: @ts-adi
Author instructions
Thanks for submitting your paper to JOSS @eidheim. Currently, there isn't an JOSS editor assigned to your paper.
@eidheim if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
The text was updated successfully, but these errors were encountered: