Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283929: GHA: Add RISC-V build config #6

Closed
wants to merge 3 commits into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Feb 21, 2024

Backport JDK-8283929, JDK-8313701 and JDK-8285630 to enable GHA cross-compiling for linux-riscv64 on riscv-port-jdk11u repo.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8283929: GHA: Add RISC-V build config (Enhancement - P4)
  • JDK-8313701: GHA: RISC-V should use the official repository for bootstrap (Enhancement - P4)
  • JDK-8285630: Fix a configure error in RISC-V cross build (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/6/head:pull/6
$ git checkout pull/6

Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/6/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6

View PR using the GUI difftool:
$ git pr show -t 6

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/6.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 85d4b49151e9529051f1ed344749a487d3e92165 8283929: GHA: Add RISC-V build config Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 21, 2024
@zifeihan
Copy link
Member Author

/issue add 8313701,8285630

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@zifeihan
Adding additional issue to issue list: 8313701: GHA: RISC-V should use the official repository for bootstrap.

Adding additional issue to issue list: 8285630: Fix a configure error in RISC-V cross build.

@zifeihan zifeihan force-pushed the backport-JDK-8283929 branch from 331cd23 to 3b4bee3 Compare February 22, 2024 02:09
@zifeihan zifeihan marked this pull request as ready for review February 22, 2024 02:10
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 22, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 22, 2024

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks. I see GHA test is all green [1].

[1] https://github.com/zifeihan/riscv-port-jdk11u/actions/runs/7998449895

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@zifeihan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283929: GHA: Add RISC-V build config
8313701: GHA: RISC-V should use the official repository for bootstrap
8285630: Fix a configure error in RISC-V cross build

Reviewed-by: fyang, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 22, 2024
@RealFYang
Copy link
Member

RealFYang commented Feb 22, 2024

BTW: The ops has reconfigured this repo (and friends) so that GHA test results will be displayed on PRs against it. Now I see it's working for this PR :-)

@zifeihan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 23, 2024
@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@zifeihan
Your change (at version 3b4bee3) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

Going to push as commit ce3a667.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 23, 2024
@openjdk openjdk bot closed this Feb 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 23, 2024
@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@RealFYang @zifeihan Pushed as commit ce3a667.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zifeihan zifeihan deleted the backport-JDK-8283929 branch February 23, 2024 02:00
@RealFYang
Copy link
Member

RealFYang commented Feb 26, 2024

@shipilev : Hi Aleksey, May I ask if we could have some full-featured RISC-V JDK daily builds with riscv-port-jdk11u repo on https://builds.shipilev.net? For now, I only see RISC-V Zero builds there [1]. Thanks.

[1] https://builds.shipilev.net/openjdk-jdk11-riscv/

@shipilev
Copy link
Member

@shipilev : Hi Aleksey, May I ask if we could have some full-featured RISC-V JDK daily builds with riscv-port-jdk11u repo on https://builds.shipilev.net? For now, I only see RISC-V Zero builds there [1]. Thanks.

Right. The build config did not enable RISC-V Server builds, because the port was not there until recently. I have enabled Server instead of Zero for that repo, and it should be rebuilding now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants