-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283929: GHA: Add RISC-V build config #6
Conversation
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/issue add 8313701,8285630 |
@zifeihan Adding additional issue to issue list: |
331cd23
to
3b4bee3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks. I see GHA test is all green [1].
[1] https://github.com/zifeihan/riscv-port-jdk11u/actions/runs/7998449895
@zifeihan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
BTW: The ops has reconfigured this repo (and friends) so that GHA test results will be displayed on PRs against it. Now I see it's working for this PR :-) |
/integrate |
/sponsor |
Going to push as commit ce3a667. |
@RealFYang @zifeihan Pushed as commit ce3a667. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
@shipilev : Hi Aleksey, May I ask if we could have some full-featured RISC-V JDK daily builds with |
Right. The build config did not enable RISC-V Server builds, because the port was not there until recently. I have enabled Server instead of Zero for that repo, and it should be rebuilding now. |
Backport JDK-8283929, JDK-8313701 and JDK-8285630 to enable GHA cross-compiling for linux-riscv64 on riscv-port-jdk11u repo.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/6/head:pull/6
$ git checkout pull/6
Update a local copy of the PR:
$ git checkout pull/6
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/6/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6
View PR using the GUI difftool:
$ git pr show -t 6
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/6.diff
Webrev
Link to Webrev Comment