Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285303: riscv: Incorrect register mask in call_native_base #18

Closed
wants to merge 1 commit into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Apr 1, 2024

Hi, please help review this backport to riscv-port-jdk11u.
Backport of JDK-8285303. Applies cleanly.

Testing:

  • Run tier1-3 tests on SOPHON SG2042 (release)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285303: riscv: Incorrect register mask in call_native_base (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk11u.git pull/18/head:pull/18
$ git checkout pull/18

Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.org/riscv-port-jdk11u.git pull/18/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18

View PR using the GUI difftool:
$ git pr show -t 18

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk11u/pull/18.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 1, 2024

@zifeihan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285303: riscv: Incorrect register mask in call_native_base

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport b10833bbf3cd33c6e6a4cf2671f587a27c606ebb 8285303: riscv: Incorrect register mask in call_native_base Apr 1, 2024
@openjdk
Copy link

openjdk bot commented Apr 1, 2024

This backport pull request has now been updated with issue from the original commit.

@zifeihan zifeihan marked this pull request as ready for review April 1, 2024 14:29
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2024

Webrevs

@zifeihan
Copy link
Member Author

zifeihan commented Apr 3, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 3, 2024
@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@zifeihan
Your change (at version 2dd5675) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 3, 2024

Going to push as commit ec98a69.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 3, 2024
@openjdk openjdk bot closed this Apr 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 3, 2024
@openjdk
Copy link

openjdk bot commented Apr 3, 2024

@RealFYang @zifeihan Pushed as commit ec98a69.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zifeihan zifeihan deleted the backport-JDK-8285303 branch April 10, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants