8349717: [leyden] compiler/inlining/LateInlinePrinting.java is failing

[shipilev]

There are lots of mainline reports about this test, see links. We see a failure in current GHA for Leyden. For Leyden, there are additional specifics: we print advanced compile task information in compile log, so we get indenting/format mismatches.

Leyden dumps this:

     57 W0.0 Q0.0 C0.7 3 b compiler.inlining.LateInlinePrinting$TestLateInlining::test2 (7 bytes)
                            @ 0 compiler.inlining.LateInlinePrinting$TestLateInlining::test3 (1 bytes) inline (hot) late inline succeeded
                            @ 3 compiler.inlining.LateInlinePrinting$TestLateInlining::testFailInline (1 bytes) failed to inline: disallowed by CompileCommand
                            @ 6 compiler.inlining.LateInlinePrinting$TestLateInlining::testFailInline (1 bytes) failed to inline: disallowed by CompileCommand
                            @ 9 compiler.inlining.LateInlinePrinting$TestLateInlining::test2 (7 bytes) inline (hot) late inline succeeded
                              @ 0 compiler.inlining.LateInlinePrinting$TestLateInlining::inlined1 (1 bytes) inline (hot) late inline succeeded
                              @ 3 compiler.inlining.LateInlinePrinting$TestLateInlining::inlined2 (1 bytes) inline (hot) late inline succeeded
     58 W0.0 Q0.0 C1.1 4 b compiler.inlining.LateInlinePrinting$TestLateInlining::test1 (13 bytes)

So, this bug fixes the test for Leyden specifically, while mainline is figuring out the rest.

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8349717: [leyden] compiler/inlining/LateInlinePrinting.java is failing (Bug - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/leyden.git pull/35/head:pull/35
$ git checkout pull/35

Update a local copy of the PR:
$ git checkout pull/35
$ git pull https://git.openjdk.org/leyden.git pull/35/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 35

View PR using the GUI difftool:
$ git pr show -t 35

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/leyden/pull/35.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into premain will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349717: [leyden] compiler/inlining/LateInlinePrinting.java is failing

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the premain branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (82628e96)

[vnkozlov]

Good.
I did not know about """ support by C++.

[shipilev]

Good. I did not know about """ support by C++.

This is multi-line String (text blocks) from https://openjdk.org/jeps/378 :)

[shipilev]

/integrate

[openjdk]

@shipilev
Your change (at version 82628e9) is now ready to be sponsored by a Committer.

[vnkozlov]

/sponsor

[vnkozlov]

We really need to make you committer.

[openjdk]

Going to push as commit ccc8d7a.

[openjdk]

@vnkozlov @shipilev Pushed as commit ccc8d7a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.