Skip to content

Conversation

satyenme
Copy link

@satyenme satyenme commented Oct 7, 2025

Backporting JDK-8353483: Open source some JProgressBar tests. Adds four progress bar tests. Ran GHA Sanity Checks and new tests directly. Patch is clean. Backporting for parity with Oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8353483 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8353483: Open source some JProgressBar tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4020/head:pull/4020
$ git checkout pull/4020

Update a local copy of the PR:
$ git checkout pull/4020
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4020/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4020

View PR using the GUI difftool:
$ git pr show -t 4020

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4020.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 7, 2025

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353483: Open source some JProgressBar tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 46a6fc84ef17f38eedd49f59a3c05f7c95fe23bc 8353483: Open source some JProgressBar tests Oct 7, 2025
@openjdk
Copy link

openjdk bot commented Oct 7, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 7, 2025
@openjdk
Copy link

openjdk bot commented Oct 7, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 7, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2025

Webrevs

@satyenme
Copy link
Author

satyenme commented Oct 7, 2025

/approval request for backport of JDK-8353483: Open source some JProgressBar tests

Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle.

Risk: Low. Ran GHA Sanity Checks and new manual tests. Patch is clean. Although change has only been present in tip since April, 2025, change has been accepted by Oracle (and tests were previously closed source).

@openjdk
Copy link

openjdk bot commented Oct 7, 2025

@satyenme
8353483: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant