8310049: Refactor Charset tests to use JUnit

[GoeLin]

I backport this for parity with 17.0.18-oracle.

I had to resolve as 8260265: UTF-8 by Default is not in 17.

The most notable difference is that I omitted the method defaultCharsetTest()
rather at the beginning, which replaces the try/catch added by 8260265 at the end.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8310049 needs maintainer approval

Issue

• JDK-8310049: Refactor Charset tests to use JUnit (Sub-task - P4 - Approved)

Reviewers

• Ralf Schmelter (@schmelter-sap - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4015/head:pull/4015
$ git checkout pull/4015

Update a local copy of the PR:
$ git checkout pull/4015
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4015

View PR using the GUI difftool:
$ git pr show -t 4015

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4015.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310049: Refactor Charset tests to use JUnit

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 2ed5a8b: 8353592: Open source several scrollbar tests
• 4f053ec: 8353483: Open source some JProgressBar tests
• 82f1ed6: 8339280: jarsigner -verify performs cross-checking between CEN and LOC
• ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/c363d3f14fda2945021ea374383a660964b2b1c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (0ba3727f)

[schmelter-sap]

Looks good

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[justin-curtis-lu]

Please see the same concerns as suggested here: https://github.com/openjdk/jdk21u-dev/pull/2296/files#r2411376021.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 9ae44ef.
Since your change was applied there have been 12 commits pushed to the master branch:

• 35dbfb2: 8288109: HttpExchangeImpl.setAttribute does not allow null value after JDK-8266897
• 9936f31: 8299553: Make ScaledEtchedBorderTest.java comprehensive
• 235637c: 8282047: Enhance StringDecode/Encode microbenchmarks
• ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/c363d3f14fda2945021ea374383a660964b2b1c4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 9ae44ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.