Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 5, 2025

I backport this for parity with 17.0.18-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8349188 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8349188: LineBorder does not scale correctly (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4014/head:pull/4014
$ git checkout pull/4014

Update a local copy of the PR:
$ git checkout pull/4014
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4014/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4014

View PR using the GUI difftool:
$ git pr show -t 4014

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4014.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/4013 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 5, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349188: LineBorder does not scale correctly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 24117c6e9aa862bad839e93eff70810a75605ac5 8349188: LineBorder does not scale correctly Oct 5, 2025
@openjdk
Copy link

openjdk bot commented Oct 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Oct 5, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 5, 2025

Webrevs

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Oct 5, 2025
@GoeLin GoeLin force-pushed the goetz_backport_8349188 branch from 69a16e8 to 96603a7 Compare October 5, 2025 18:03
@openjdk
Copy link

openjdk bot commented Oct 5, 2025

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added clean Identical backport; no merge resolution required approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Oct 5, 2025
@GoeLin GoeLin changed the base branch from pr/4013 to master October 8, 2025 06:59
@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Oct 8, 2025
@openjdk openjdk bot added clean Identical backport; no merge resolution required ready Pull request is ready to be integrated labels Oct 8, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 8, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 8, 2025

Going to push as commit 7341302.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 8, 2025
@openjdk openjdk bot closed this Oct 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 8, 2025
@openjdk
Copy link

openjdk bot commented Oct 8, 2025

@GoeLin Pushed as commit 7341302.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8349188 branch October 8, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant