Skip to content

Conversation

kirill-shirokov
Copy link

@kirill-shirokov kirill-shirokov commented Sep 16, 2025

The backport verified on MacOS/Linux/Windows by manually running JITTester.

Verification involved modifying JITTester code to terminate with non-zero exit code when encountering specific compilation error (a break statement in a static initializer) in the generated code and enabling static initializer generation in configuration file in non-fixed version.

Without the fix typically the error reproduces during the first generation round.
With the fix, there is no error for 10s of rounds.


Progress

  • JDK-8337102 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8337102: JITTester: Fix breaks in static initialization blocks (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3941/head:pull/3941
$ git checkout pull/3941

Update a local copy of the PR:
$ git checkout pull/3941
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3941/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3941

View PR using the GUI difftool:
$ git pr show -t 3941

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3941.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Sep 16, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2025

Hi @kirill-shirokov, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user kirill-shirokov" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@kirill-shirokov
Copy link
Author

/covered

@openjdk
Copy link

openjdk bot commented Sep 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Sep 16, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk openjdk bot changed the title Backport 4669e7b7b02636a8bd7381a9d401aaaf0c1d7294 8337102: JITTester: Fix breaks in static initialization blocks Sep 16, 2025
@openjdk
Copy link

openjdk bot commented Sep 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant