Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333824: Unused ClassValue in VarHandles #2972

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link

@satyenme satyenme commented Oct 17, 2024

Backporting JDK-8333824: Unused ClassValue in VarHandles. Removes completely unused code. Likely a leftover. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is almost clean: it does not remove an import used in JDK <=21.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333824 needs maintainer approval

Issue

  • JDK-8333824: Unused ClassValue in VarHandles (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2972/head:pull/2972
$ git checkout pull/2972

Update a local copy of the PR:
$ git checkout pull/2972
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2972/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2972

View PR using the GUI difftool:
$ git pr show -t 2972

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2972.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2024

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 7b43a8cd7c663facbe490f889838d7ead0eba0f9 8333824: Unused ClassValue in VarHandles Oct 17, 2024
@openjdk
Copy link

openjdk bot commented Oct 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 17, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 17, 2024

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants