Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314610: hotspot can't compile with the latest of gtest because of <iomanip> #2959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sorna-Sarathi
Copy link

@Sorna-Sarathi Sorna-Sarathi commented Oct 14, 2024

Hi all,
This pull request contains a backport of commit febc34d from the openjdk/jdk repository.
Tier1 testing is successful.
Thanks!

JBS Issue: JDK-8314610


Progress

  • JDK-8314610 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Warning

 ⚠️ Found leading lowercase letter in issue title for 8314610: hotspot can't compile with the latest of gtest because of <iomanip>

Issue

  • JDK-8314610: hotspot can't compile with the latest of gtest because of <iomanip> (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2959/head:pull/2959
$ git checkout pull/2959

Update a local copy of the PR:
$ git checkout pull/2959
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2959/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2959

View PR using the GUI difftool:
$ git pr show -t 2959

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2959.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 14, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2024

Hi @Sorna-Sarathi, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Sorna-Sarathi" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport febc34dd285c3382716e068748d4a3b0c73d87ad 8314610: hotspot can't compile with the latest of gtest because of <iomanip> Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

This backport pull request has now been updated with issue from the original commit.

@Sorna-Sarathi
Copy link
Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Oct 14, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2024

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant