Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327474: Review use of java.io.tmpdir in jdk tests #2811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 16, 2024

Hi all,

This pull request contains a backport of commit af6c5854 from the openjdk/jdk21u-dev repository.

The commit being backported was authored by Goetz Lindenmaier on 22 Apr 2024 and had no reviewers.

The backport not clean because jdk17u-dev doesn't have test/jdk/jdk/jfr/threading/TestManyVirtualThreads.java, all other files are backported cleanly.
Existing tests should be reviewed to check the usage of java.io.tmpdir. Test fix only, the risk is low.

Additional testing:

  • full jtreg tests on linux x64
  • full jtreg tests in linux aarch64

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8327474 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8327474: Review use of java.io.tmpdir in jdk tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2811/head:pull/2811
$ git checkout pull/2811

Update a local copy of the PR:
$ git checkout pull/2811
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2811/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2811

View PR using the GUI difftool:
$ git pr show -t 2811

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2811.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 16, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport af6c5854235573a29b6b418e9f759e2564bca63a 8327474: Review use of java.io.tmpdir in jdk tests Aug 16, 2024
@openjdk
Copy link

openjdk bot commented Aug 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 16, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 16, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Existing tests should be reviewed to check the usage of java.io.tmpdir. Test fix only, the risk is low.

@openjdk
Copy link

openjdk bot commented Aug 23, 2024

@sendaoYan
8327474: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Aug 23, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Hi, can anyone take look tihs PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants