Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts #2747

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexeybakhtin
Copy link

@alexeybakhtin alexeybakhtin commented Jul 28, 2024

Hello, I'd like to backport JDK-8179502 to JDK17u to improve the timeout adjustment for OCSP GET requests (which was missed in JDK-8179503).

The backport is almost clean except for the following:

  • OCSP.java was merged manually because of JDK-8328638 and JDK-8329213 is already backported into 17u-dev
  • copyright year in GetPropertyAction.java and URICertStore.java files are updated manually
  • CRLReadTimeout.java test is updated manually because of the different notation of internal X509CRLImpl and CRLExtensions classes.

All new and related jtreg tests are passed


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8337407 to be approved
  • JDK-8179502 needs maintainer approval

Issues

  • JDK-8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts (Enhancement - P4)
  • JDK-8337407: Enhance OCSP, CRL and Certificate Fetch Timeouts (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2747/head:pull/2747
$ git checkout pull/2747

Update a local copy of the PR:
$ git checkout pull/2747
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2747/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2747

View PR using the GUI difftool:
$ git pr show -t 2747

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2747.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2024

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 28, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 2836c34b64e4626e25c86a53e5bef2bf32f95d2e 8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts Jul 28, 2024
@openjdk
Copy link

openjdk bot commented Jul 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jul 28, 2024
@openjdk
Copy link

openjdk bot commented Jul 28, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jul 28, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2024

Webrevs

@alexeybakhtin
Copy link
Author

CSR JDK-8337407 for JDK17 is created

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 27, 2024

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@HempushpaSahu
Copy link

Hi @alexeybakhtin
Is there any plan to merge this PR anytime soon?

Thanks.

@alexeybakhtin
Copy link
Author

Hi @HempushpaSahu. Yes, I will request integration into 17u as soon as it is reviewed here.

@HempushpaSahu
Copy link

Hi @alexeybakhtin,
I noticed from JDK-8337407 issue, jnimeh is the reviewer.
Could you please confirm whether the review is currently in progress?
Also, is it possible to assign an additional reviewer if one is available?

Thanks.

@alexeybakhtin
Copy link
Author

Hello everyone,
Could you please review the backport? I want to backport it for parity with Oracle.

@HempushpaSahu
Copy link

Hi,
Since there is multiple follow-ups for this PR and customer is awaiting the fix, could someone please provide an update on the review status?

Thanks.

@HempushpaSahu
Copy link

Hi,
Could someone please review the PR?

Thanks.

@HempushpaSahu
Copy link

HempushpaSahu commented Oct 7, 2024

Hi @jnimeh ,
Could you please assist with reviewing the PR or if you are occupied with other tasks please tag the appropriate person who can help us to review?
The customer is waiting for the fix. Once this backport is merged, they will be able to move forward.

Thanks.

@jnimeh
Copy link
Member

jnimeh commented Oct 7, 2024

Hello @HempushpaSahu. I can review the CSR. I think you need someone who has reviewer status in the jdk-updates project in order to be able to commit this. I only have committer status there. You should be able to find many folks with jdk-updates reviewer status on the OpenJDK census page though.

@jnimeh
Copy link
Member

jnimeh commented Oct 7, 2024

I would also suggest looking at incorporating JDK-8309740 and JDK-8309754 in follow-on integrations as they pertain to the tests in this PR.

@HempushpaSahu
Copy link

Hi @seanjmullan ,
Could you please help us here to review the PR?

@HempushpaSahu
Copy link

Hello @HempushpaSahu. I can review the CSR. I think you need someone who has reviewer status in the jdk-updates project in order to be able to commit this. I only have committer status there. You should be able to find many folks with jdk-updates reviewer status on the OpenJDK census page though.

Thanks @jnimeh for your inputs.

@HempushpaSahu
Copy link

Hi @GoeLin
Could you please help to review this PR or tag the appropriate person who can help us to review?
Thanks.

@HempushpaSahu
Copy link

Hi @GoeLin
Could you please help to review this PR?
Thanks.

@HempushpaSahu
Copy link

Hi @alexeybakhtin,
JDK-8337407 issue has some activity in last week.
Could you please confirm whether the review is currently in progress?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants