-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8179502: Enhance OCSP, CRL and Certificate Fetch Timeouts #2747
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the |
CSR JDK-8337407 for JDK17 is created |
@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi @alexeybakhtin Thanks. |
Hi @HempushpaSahu. Yes, I will request integration into 17u as soon as it is reviewed here. |
Hi @alexeybakhtin, Thanks. |
Hello everyone, |
Hi, Thanks. |
Hi, Thanks. |
Hi @jnimeh , Thanks. |
Hello @HempushpaSahu. I can review the CSR. I think you need someone who has reviewer status in the jdk-updates project in order to be able to commit this. I only have committer status there. You should be able to find many folks with jdk-updates reviewer status on the OpenJDK census page though. |
I would also suggest looking at incorporating JDK-8309740 and JDK-8309754 in follow-on integrations as they pertain to the tests in this PR. |
Hi @seanjmullan , |
Thanks @jnimeh for your inputs. |
Hi @GoeLin |
Hi @GoeLin |
Hi @alexeybakhtin, Thanks. |
Hello, I'd like to backport JDK-8179502 to JDK17u to improve the timeout adjustment for OCSP GET requests (which was missed in JDK-8179503).
The backport is almost clean except for the following:
All new and related jtreg tests are passed
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2747/head:pull/2747
$ git checkout pull/2747
Update a local copy of the PR:
$ git checkout pull/2747
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2747/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2747
View PR using the GUI difftool:
$ git pr show -t 2747
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2747.diff
Webrev
Link to Webrev Comment