-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8319569: Several java/util tests should be updated to accept VM flags #2620
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
depends JDK-8315097 |
@sendaoYan this pull request can not be integrated into git checkout jbs8319569
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@sendaoYan This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
wait. |
Hi all,
This pull request contains a backport of commit 2bb4b939 from the openjdk/jdk repository.
The commit being backported was authored by Justin Lu on 23 Nov 2023 and was reviewed by Naoto Sato and Lance Andersen.
There are two files make this backport not clean:
test/jdk/java/util/Currency/PropertiesTest.sh
test/jdk/java/util/TimeZone/CustomTzIDCheckDST.java
has previous change before the backport PR in jdk-tipAdditional testing
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2620/head:pull/2620
$ git checkout pull/2620
Update a local copy of the PR:
$ git checkout pull/2620
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2620/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2620
View PR using the GUI difftool:
$ git pr show -t 2620
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2620.diff
Webrev
Link to Webrev Comment