8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'

[zifeihan]

Hi, This is also needed for riscv-port-jdk11u repo where we have full-reatured linux-riscv port for the same reason as jdk17u backport. The backport is not clean because the sparc architecture related code still exists. Risk is low as this is a small change prefering using PTRACE_GETREGSET instead of PTRACE_GETREGS. Tested on linux-aarch64 and linux-x86_64 platforms.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8307955 needs maintainer approval

Issue

• JDK-8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs' (Bug - P4 - Approved)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Guoxiong Li (@lgxbslgx - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2549/head:pull/2549
$ git checkout pull/2549

Update a local copy of the PR:
$ git checkout pull/2549
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2549/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2549

View PR using the GUI difftool:
$ git pr show -t 2549

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2549.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (ac28b40d)
• 00: Full (926d7fef)

[RealFYang]

LGTM.

[openjdk]

⚠️ @zifeihan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[lgxbslgx]

Looks good.

[openjdk]

@zifeihan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'

Reviewed-by: fyang, gli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 5045b54: 8214400: Update hotspot application/jcstress jtreg tests wrappers to use jcstress 0.5
• 6e296a0: 8326801: Bump update version for OpenJDK: jdk-11.0.24
• 1bb3ed3: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
• d2d988a: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar
• 64269a3: 8285756: clean up use of bad arguments for @clean in langtools tests
• 7bed7f1: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11
• 10f0884: 8207855: Make applications/jcstress invoke tests in batches
• a855cab: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
• a60a5c4: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
• 93c5f7c: 8326503: [11u] java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fail because of package org.junit.jupiter.api does not exist
• ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/e075097dc849eb3b66648d2392205aecac9aeeaa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[zifeihan]

Thanks for all review.

[zifeihan]

/integrate

[openjdk]

@zifeihan
Your change (at version ac28b40) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit 0e94be6.
Since your change was applied there have been 15 commits pushed to the master branch:

• 2dee6fb: 8294156: Allow PassFailJFrame.Builder to create test UI
• c681c5a: 8316053: Open some swing tests 3
• e5cc20c: 8315726: Open source several AWT applet tests
• fe840ca: 8314830: runtime/ErrorHandling/ tests ignore external VM flags
• 5045b54: 8214400: Update hotspot application/jcstress jtreg tests wrappers to use jcstress 0.5
• 6e296a0: 8326801: Bump update version for OpenJDK: jdk-11.0.24
• 1bb3ed3: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
• d2d988a: 8292182: [TESTLIB] Enhance JAXPPolicyManager to setup required permissions for jtreg version 7 jar
• 64269a3: 8285756: clean up use of bad arguments for @clean in langtools tests
• 7bed7f1: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11
• ... and 5 more: https://git.openjdk.org/jdk11u-dev/compare/e075097dc849eb3b66648d2392205aecac9aeeaa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @zifeihan Pushed as commit 0e94be6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.