8354053: Remove unused JavaIOFilePermissionAccess

[RogerRiggs]

The JavaIOFilePermissionAccess interface is removed from SharedSecrets and its implementation (FilePermCompat.java) used by the test is moved to java.io FilePermission where cross package access is not needed.
The test FilePermissionCollectionMerge is updated to access the internal implementation in FilePermission.
Modernized the initialization from the system property jdk.io.permissionsUseCanonicalPath.
The remaining support will be removed when FilePermission is removed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354053: Remove unused JavaIOFilePermissionAccess (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24603/head:pull/24603
$ git checkout pull/24603

Update a local copy of the PR:
$ git checkout pull/24603
$ git pull https://git.openjdk.org/jdk.git pull/24603/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24603

View PR using the GUI difftool:
$ git pr show -t 24603

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24603.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@RogerRiggs The following labels will be automatically applied to this pull request:

• core-libs
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (721fba81)

[liach]

That test is already calling with reflection and +open, we can just make this private and non-static.

The last use of the original methods were removed when AccessControlContext was functionally removed. If security developers can check, maybe we can just remove these methods completely?

[AlanBateman]

@wangweij Is there any reason to keep the system property jdk.io.permissionsUseCanonicalPath ?

[wangweij]

I remember the implies method of the file permission class depends on whether this system property is set. Although file permission is no longer used in access control check the class and the method are still there.

[AlanBateman]

I remember the implies method of the file permission class depends on whether this system property is set. Although file permission is no longer used in access control check the class and the method are still there.

Right, and I wasn't suggesting we remove implies(FilePermission), instead I'm wondering if the compatibility knob and the implNote can be removed. As you know, it dates from the change to FilePermission in JDK 9 to do simple path matching rather than canonicalization.

In any case, I don't want to complicate Roger's cleanup, I'm just noting that it's doing cleanup on a compatibility property that we should have removed a few releases/years ago.

[RogerRiggs]

I considered dropping the property support, but it seemed harmless to leave it until FilePermission is removed and avoids thrash in an unused implementation and documentation.