8353642: Deprecate URL::getPermission method and networking permission classes for removal #24592

dfuch · 2025-04-11T09:00:05Z

Please find her a patch that deprecate networking permission classes for removal. The method URL::getPermission now serves little purpose and is also deprecated. That method was overridden in subclasses and specified to return some of the deprecated permissions.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8354406 to be approved

Issues

JDK-8353642: Deprecate URL::getPermission method and networking permission classes for removal (Enhancement - P3)
JDK-8354406: Deprecate URL::getPermission method and networking permission classes for removal (CSR)

Reviewers

Michael McMahon (@Michael-Mc-Mahon - Reviewer)
Daniel Jeliński (@djelinski - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24592/head:pull/24592
$ git checkout pull/24592

Update a local copy of the PR:
$ git checkout pull/24592
$ git pull https://git.openjdk.org/jdk.git pull/24592/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24592

View PR using the GUI difftool:
$ git pr show -t 24592

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24592.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-04-11T09:00:50Z

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-04-11T09:01:41Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

openjdk · 2025-04-11T09:03:09Z

@dfuch The following labels will be automatically applied to this pull request:

net
nio
security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-04-11T09:06:27Z

Webrevs

dfuch · 2025-04-11T09:55:58Z

The CSR is also ready to be reviewed at https://bugs.openjdk.org/browse/JDK-8354406

djelinski · 2025-04-11T10:45:20Z

src/java.base/share/classes/java/net/HttpURLConnection.java

     */
+    @Deprecated(since = "25")


can this (and all other getPermission methods) be "forRemoval=true"?

Possibly. @AlanBateman may have some thoughts on this.

I think we should at least consider deprecating URLConnection.getPermission and HttpURLConnection.getPermission for removal, only because I don't immediately see the advantage of doing it in two steps for these two APIs.

Thanks - I will do that then

djelinski · 2025-04-11T10:55:10Z

src/java.base/share/classes/java/security/CodeSource.java

                }
-                return this.sp.implies(that.sp);
+                @SuppressWarnings("removal")
+                var result = this.sp.implies(that.sp);


Will we need to rewrite this code without SocketPermissions? Can we remove it, maybe? It is only used by CodeSource.implies, which is not used by the JDK (but may be used elsewhere).

also the JavaDoc of the implies method references the SocketPermission. That will also need to be cleaned up at some point.

That will be left over for someone in security-libs to cleanup this code at their convenience before we remove SocketException.

Hmmm... If the public API references SocketException we might have to deprecate in this PR too. Not sure what the implications are. Maybe @seanjmullan can advise.

djelinski · 2025-04-11T11:16:48Z

src/java.base/share/classes/java/net/SocketPermission.java

@@ -1305,6 +1307,8 @@ public static void main(String args[]) throws Exception {
 * @serial include
 */

+@SuppressWarnings("removal")
+@Deprecated(since = "25", forRemoval = true)


this class is internal, no need to deprecate

It helps getting warnings at the place where the class is used.

djelinski · 2025-04-11T12:01:52Z

The GHA failure (Windows) appears to be related.

dfuch · 2025-04-11T12:31:04Z

The GHA failure (Windows) appears to be related.

Yes - I missed one windows specific file in my original patch. I have a test running in the CI and I am waiting for it to pass before updating the PR.

Michael-Mc-Mahon · 2025-04-11T13:47:10Z

src/java.base/share/classes/java/security/CodeSource.java

@@ -456,12 +457,16 @@ private boolean matchLocation(CodeSource that) {
                    return false;
                }
                if (this.sp == null) {
-                    this.sp = new SocketPermission(thisHost, "resolve");
+                    @SuppressWarnings("removal")
+                    var _ = this.sp = new SocketPermission(thisHost, "resolve");


What's the reason for the var _ = bit ?

@SuppressWarnings can not be applied to a an expression - it needs a (variable/method/class) declaration

dfuch · 2025-04-11T13:57:35Z

The GHA failure (Windows) appears to be related.

Should be fixed now

Michael-Mc-Mahon

Looks fine to me.

djelinski

LGTM.

8353642: Deprecate networking permission classes for removal

e9dc414

openjdk bot added the rfr Pull request is ready for review label Apr 11, 2025

openjdk bot added security security-dev@openjdk.org nio nio-dev@openjdk.org net net-dev@openjdk.org labels Apr 11, 2025

openjdk bot added the csr Pull request needs approved CSR before integration label Apr 11, 2025

Missing white spaces

9b371b3

djelinski reviewed Apr 11, 2025

View reviewed changes

Michael-Mc-Mahon reviewed Apr 11, 2025

View reviewed changes

Review feedback. Deprecate getPermission for removal.

d47a31d

dfuch changed the title ~~8353642: Deprecate networking permission classes for removal~~ 8353642: Deprecate URL::getPermission method and networking permission classes for removal Apr 11, 2025

Michael-Mc-Mahon approved these changes Apr 11, 2025

View reviewed changes

djelinski approved these changes Apr 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8353642: Deprecate URL::getPermission method and networking permission classes for removal #24592

8353642: Deprecate URL::getPermission method and networking permission classes for removal #24592

dfuch commented Apr 11, 2025 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 11, 2025

openjdk bot commented Apr 11, 2025

openjdk bot commented Apr 11, 2025

mlbridge bot commented Apr 11, 2025 •

edited

Loading

dfuch commented Apr 11, 2025 •

edited

Loading

djelinski Apr 11, 2025

dfuch Apr 11, 2025

AlanBateman Apr 11, 2025

dfuch Apr 11, 2025

dfuch Apr 11, 2025

djelinski Apr 11, 2025

djelinski Apr 11, 2025

dfuch Apr 11, 2025

djelinski Apr 11, 2025

dfuch Apr 11, 2025 •

edited

Loading

djelinski commented Apr 11, 2025

dfuch commented Apr 11, 2025 •

edited

Loading

Michael-Mc-Mahon Apr 11, 2025

dfuch Apr 11, 2025 •

edited

Loading

dfuch commented Apr 11, 2025

Michael-Mc-Mahon left a comment

djelinski left a comment

8353642: Deprecate URL::getPermission method and networking permission classes for removal #24592

Are you sure you want to change the base?

8353642: Deprecate URL::getPermission method and networking permission classes for removal #24592

Conversation

dfuch commented Apr 11, 2025 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

bridgekeeper bot commented Apr 11, 2025

openjdk bot commented Apr 11, 2025

openjdk bot commented Apr 11, 2025

mlbridge bot commented Apr 11, 2025 • edited Loading

Webrevs

dfuch commented Apr 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dfuch Apr 11, 2025 • edited Loading

Choose a reason for hiding this comment

djelinski commented Apr 11, 2025

dfuch commented Apr 11, 2025 • edited Loading

Choose a reason for hiding this comment

dfuch Apr 11, 2025 • edited Loading

Choose a reason for hiding this comment

dfuch commented Apr 11, 2025

Michael-Mc-Mahon left a comment

Choose a reason for hiding this comment

djelinski left a comment

Choose a reason for hiding this comment

dfuch commented Apr 11, 2025 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 11, 2025 •

edited

Loading

dfuch commented Apr 11, 2025 •

edited

Loading

dfuch Apr 11, 2025 •

edited

Loading

dfuch commented Apr 11, 2025 •

edited

Loading

dfuch Apr 11, 2025 •

edited

Loading