8354309: Sort GC includes

[stefank]

We now have a tool to fix our include lines to better adhere to the HotSpot Style Guide. See test/hotspot/jtreg/sources/SortIncludes.java. I've run the tool against the GC code and propose the resulting changes. I did one manual change to move a section guarded with INCLUDE_JFR.

Builds successfully with GHA. I will run this through tier1-2.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354309: Sort GC includes (Enhancement - P4)

Reviewers

• Erik Österlund (@fisk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24581/head:pull/24581
$ git checkout pull/24581

Update a local copy of the PR:
$ git checkout pull/24581
$ git pull https://git.openjdk.org/jdk.git pull/24581/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24581

View PR using the GUI difftool:
$ git pr show -t 24581

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24581.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354309: Sort GC includes

Reviewed-by: eosterlund, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• e604bb9: 8352731: Compiler workaround to forcibly set "-Xlint:-options" can be removed
• 2321722: 8346109: Create JDK taglet for additional preview notes
• 9ead2b7: 8354180: Clean up uses of ObjectMonitor caches
• ... and 29 more: https://git.openjdk.org/jdk/compare/7e69b98e0548803b85b04b518929c073f8ffaf8c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@stefank The following labels will be automatically applied to this pull request:

• hotspot
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cf81077d)

[fisk]

Nice. Looks good.

[walulyai]

LGTM!

[kimbarrett]

Need to update the list of source directories to check in the test.
https://github.com/openjdk/jdk/blame/d4e194bc463ff3ad09e55cbb96bea00283679ce6/test/hotspot/jtreg/sources/TestIncludesAreSorted.java#L45-L50

[stefank]

I don't think my patch needs to add this to the test.

Adding the GC directories to the test will make a small mistake in the include order a tier1 failure, and I'm not yet convinced that that is a good thing compared to lazily fixing sort order problems.

Any other Reviewers that have a strong opinion about this?

[tschatzl]

Any other Reviewers that have a strong opinion about this?

Not a strong opinion, but I would prefer to check automatically in some way. Does not need every run of tier1.