8331399: RISC-V: Don't us mv instead of la

[robehn]

Hi please consider,

It makes no sense to use mv instead of la.
It doesn't follow the standard mnemonics and it confusing when people use mv when they really mean la.

la will do the reloc with movptr in this case, so the code is the same.

Testing t1.

Thanks, Robbin

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8331399: RISC-V: Don't us mv instead of la (Enhancement - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Hamlin Li (@Hamlin-Li - Reviewer)
• Antonios Printezis (@gctony - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19014/head:pull/19014
$ git checkout pull/19014

Update a local copy of the PR:
$ git checkout pull/19014
$ git pull https://git.openjdk.org/jdk.git pull/19014/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19014

View PR using the GUI difftool:
$ git pr show -t 19014

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19014.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331399: RISC-V: Don't us mv instead of la

Reviewed-by: fyang, mli, tonyp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 4f529f8: 8331427: Rename confusingly named ArraysSupport.signedHashCode
• 44dc850: 8331212: Error recovery for broken switch expressions could be improved
• b2fb5ea: 8331142: Add test for number of loader threads in BasicDirectoryModel
• 663acd2: 8330969: scalability issue with loaded JVMTI agent
• f215899: 8331393: AArch64: u32 _partial_subtype_ctr loaded/stored as 64
• b96b38c: 8318682: SA decoding of scalar replaced objects is broken
• a863ef5: 8331207: Misleading example in DateFormat#parse docs
• aca1e83: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
• 3d11692: 8331252: C2: MergeStores: handle negative shift values
• 9ce21d1: 8327647: Occasional SIGSEGV in markWord::displaced_mark_helper() for SPECjvm2008 sunflow
• ... and 10 more: https://git.openjdk.org/jdk/compare/819f3d6fc70ff6fe54ac5f9033c17c3dd4326aa5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@robehn The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (05f1a603)

[RealFYang]

Yes. that looks more reasonable. Thanks for the cleanup.

[robehn]

Yes. that looks more reasonable. Thanks for the cleanup.

Thanks!

[Hamlin-Li]

Looks good, thanks!

[robehn]

/integrate

[openjdk]

Going to push as commit dd906ff.
Since your change was applied there have been 29 commits pushed to the master branch:

• d3bf526: 8331518: Tests should not use the "Classpath" exception form of the legal header
• 4036d7d: 8330076: NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API
• 9108091: 8330989: unify os::create_binary_file across platforms
• 5ab8713: 8331360: RISCV: u32 _partial_subtype_ctr loaded/stored as 64
• 19e46ee: 8331088: Incorrect TraceLoopPredicate output
• 0a24dae: 8322043: HeapDumper should use parallel dump by default
• 62d5d1e: 8319598: SMFParser misinterprets interrupted running status
• 2a95cd4: 8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only
• e833bfc: 8331222: Malformed text in the jpackage doc page
• 4f529f8: 8331427: Rename confusingly named ArraysSupport.signedHashCode
• ... and 19 more: https://git.openjdk.org/jdk/compare/819f3d6fc70ff6fe54ac5f9033c17c3dd4326aa5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robehn Pushed as commit dd906ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.