Skip to content

Commit

Permalink
8286172: Create an automated test for JDK-4516019
Browse files Browse the repository at this point in the history
Reviewed-by: prr, achung
  • Loading branch information
Srinivas Mandalika authored and prrace committed Jul 18, 2022
1 parent b9de0a7 commit e72742e
Showing 1 changed file with 121 additions and 0 deletions.
121 changes: 121 additions & 0 deletions test/jdk/javax/swing/JSpinner/JSpinnerFocusTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,121 @@
/*
* Copyright (c) 2002, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @key headful
* @bug 4516019
* @summary Verify that clicking on the increment/decrement buttons
* of the spinner gives focus to the spinner.
* @run main JSpinnerFocusTest
*/

import java.awt.BorderLayout;
import java.awt.Rectangle;
import java.awt.Robot;
import java.awt.event.InputEvent;

import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JSpinner;
import javax.swing.JSpinner.DefaultEditor;
import javax.swing.SwingUtilities;

public class JSpinnerFocusTest {

JFrame jFrame;
JButton jButton;
JSpinner jSpinner;
Robot robot;

volatile Rectangle bounds;
volatile boolean jTextFieldFocusStatus = false;

private void createGUI() {
jFrame = new JFrame();
jButton = new JButton();
jSpinner = new JSpinner();

jFrame.setLayout(new BorderLayout());
jFrame.add(jButton, BorderLayout.NORTH);
jFrame.add(jSpinner, BorderLayout.CENTER);
jFrame.setLocationRelativeTo(null);
jFrame.setSize(300, 300);
jFrame.setVisible(true);
}

public void doTest() throws Exception {
try {
robot = new Robot();
robot.setAutoDelay(400);

SwingUtilities.invokeAndWait(() -> createGUI());

robot.waitForIdle();
runTest();

robot.waitForIdle();
SwingUtilities.invokeAndWait(() -> {
jTextFieldFocusStatus = ((DefaultEditor) jSpinner.getEditor())
.getTextField().isFocusOwner();
});
if (!jTextFieldFocusStatus) {
throw new RuntimeException(
"Clicking on JSpinner buttons did not"
+ " shift focus to the JSpinner");
}
} finally {
SwingUtilities.invokeAndWait(() -> {
if (jFrame != null) {
jFrame.dispose();
}
});
}
}

private void runTest() throws Exception {
SwingUtilities.invokeAndWait(() -> {
bounds = new Rectangle(jSpinner.getLocationOnScreen(),
jSpinner.getSize());
});

// Move cursor to place it in the spinner editor
robot.mouseMove(bounds.x + bounds.width / 2,
bounds.y + bounds.height / 2);

robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);

// Move cursor to click spinner up arrow button
robot.mouseMove(bounds.x + bounds.width - 2,
bounds.y + bounds.height / 4);

robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
}

public static void main(String[] args) throws Exception {
new JSpinnerFocusTest().doTest();
System.out.println("Test Passed");
}
}

5 comments on commit e72742e

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on e72742e Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk17u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on e72742e Nov 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-e72742ee in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e72742ee from the openjdk/jdk repository.

The commit being backported was authored by Srinivas Mandalika on 18 Jul 2022 and was reviewed by Phil Race and Alisen Chung.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-e72742ee:GoeLin-backport-e72742ee
$ git checkout GoeLin-backport-e72742ee
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev GoeLin-backport-e72742ee

@GoeLin
Copy link
Member

@GoeLin GoeLin commented on e72742e Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jdk11u-dev

@openjdk
Copy link

@openjdk openjdk bot commented on e72742e Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoeLin the backport was successfully created on the branch GoeLin-backport-e72742ee in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit e72742ee from the openjdk/jdk repository.

The commit being backported was authored by Srinivas Mandalika on 18 Jul 2022 and was reviewed by Phil Race and Alisen Chung.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev.git GoeLin-backport-e72742ee:GoeLin-backport-e72742ee
$ git checkout GoeLin-backport-e72742ee
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev.git GoeLin-backport-e72742ee

Please sign in to comment.