Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug split pace elevation calculation #67

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Fix bug split pace elevation calculation #67

merged 2 commits into from
Dec 6, 2023

Conversation

raditzlawliet
Copy link
Member

@raditzlawliet raditzlawliet commented Dec 4, 2023 •
edited
Loading

  • fix descent calculation missed use subtract instead sum.
  • rename ascent/descent variable.
  • update compare altitude with latest previous valid altitude (instead previous), so this will support null altitude on jumped record.

image

  • Fix wrong elevation gain on Split pace

@raditzlawliet raditzlawliet mentioned this pull request Dec 5, 2023
Merged
@raditzlawliet raditzlawliet marked this pull request as draft December 5, 2023 11:32
@raditzlawliet raditzlawliet marked this pull request as ready for review December 6, 2023 05:40
@raditzlawliet raditzlawliet merged commit abf4578 into dev Dec 6, 2023
1 check passed
@raditzlawliet raditzlawliet deleted the bug/split-pace-ascent-calculation branch December 6, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muktihari muktihari muktihari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raditzlawliet @muktihari