fix: wrong conceal or trim marker #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is updating fit sdk also a step to fixing of this issue? |
Nope, dev upstream seems outdated |
raditzlawliet
approved these changes
Oct 28, 2024
muktihari
added a commit
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user does not specify the conceal or trim parameters, the default markers are
0forstartNandlen(Records)-1forendN.Previously, the service concealed records at the start position
<= startNand at the end position>= endN, which resulted in the first and last records always being concealed. It should have been set to< startNand> endN.Some platforms, such as Runkeeper, will reject a GPX file if its
<trkpt>elements do not include thelatandlonattributes, even for a single record.This kind of issue can be minimized when we fully implement unit tests tracked on #94, but I haven't have time yet.