chore: remove wasm_exec.js from repo, update package.json and go.mod #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muktihari
added
the
chore
muktihari
requested review from
raditzlawliet
and removed request for
raditzlawliet
raditzlawliet
approved these changes
Jun 30, 2024
Yup, because when we upgrade Go version, we need wasm_exec.js that comes with that version too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm_exec.jsfrom repo since this file is tightly coupled with a specific version of Go and add it to.gitignore.package.json:npm run initto copywasm_exec.jsfrom GOROOT tosrc/assets/wasm.v0.20.1tov0.20.2and xmltokenizer fromv0.0.2tov0.0.4.