Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity CRUD Implementation Concepts #45

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

paucorre
Copy link

@paucorre paucorre commented Feb 3, 2025

Some additions to the terminology with Identity CRUD Implementation Concepts

@dhs-BI
Copy link
Contributor

dhs-BI commented Feb 4, 2025

I did a very quick review of this.

In general, I think this language is good and helpful. However, I recognize that this comes from recent work in IETF SCIM WG and is oriented toward SCIM. Since this doc is protocol agnostic, I recommend we scrub the text for anything SCIM specific and remove it in favor of more generic text.

@paucorre
Copy link
Author

paucorre commented Feb 4, 2025 via email

Copy link
Contributor

@dhs-BI dhs-BI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two lines (maybe 3 if I include the client) that could be read as SCIM-oriented. Overall this is very helpful and should be included in the terminology. My comments are nits - if there's consensus that the text is fine as is, there is no reason to hold this back from being merged.

@dhs-BI
Copy link
Contributor

dhs-BI commented Feb 4, 2025

Hi Dean, I thought I remove all references to SCIM and even change it to be protocol agnostic. In fact, I use the same concepts that is a good way to create the terminology of identity CRUD operations I might miss something but if you compare both documents you see that the SCIM IETF is very protocol oriented, but the additions to the terminology in thi document tries to be proto on agnostic, but would be great to have help in this couple of paragraphs:)

Paolo, thanks for the contribution. As I noted in the review, my comments are minor issues. If the consensus is to merge as is, I'm OK with the content.

Copy link
Contributor

@dhs-BI dhs-BI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I missed these.

@dhs-BI dhs-BI marked this pull request as draft February 9, 2025 22:08
@dhs-BI dhs-BI self-requested a review February 9, 2025 22:08
Addressed comments discussed with @paucorre in openid#45 to prepare for merging.
Copy link
Contributor

@dhs-BI dhs-BI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the updates.

@paucorre @aaronpk I can merge if you think this is ready.

@dhs-BI dhs-BI marked this pull request as ready for review February 25, 2025 16:41
Copy link
Contributor

@dhs-BI dhs-BI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - let's discuss on an upcoming call before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants