Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IPHONEOS_DEPLOYMENT_TARGET warning by upgrading iOS to 9 #673

Closed
wants to merge 1 commit into from

Conversation

minuscorp
Copy link

No description provided.

@CemYil03
Copy link

CemYil03 commented Jan 3, 2022

#661 already covers this.

@minuscorp
Copy link
Author

Still not merged though

@Oliver-Binns
Copy link

#661 is a better implementation of this. It would be preferable to merge that instead.

The platform declarations can be removed entirely as they match the minimum version supported by SPM:
https://forums.swift.org/t/xcode12-minimum-deployment-target-and-spm/40467
https://github.com/nanopb/nanopb/pull/585/files

@minuscorp
Copy link
Author

I saw it, and saw that it wasn't reviewed that's why I posted another one. I really hate warnings in projects.

@mattneub
Copy link

mattneub commented Aug 5, 2022

Please merge this change! We need to get this warning off our plate.

@petea
Copy link
Collaborator

petea commented Aug 5, 2022

This was addressed in #690 and released with 1.5.0. What warning are you seeing?

@petea petea closed this Aug 5, 2022
@mattneub
Copy link

mattneub commented Aug 5, 2022

Yes, I just realized that. The problem is that AppAuth is an indirect dependency so I'm not certain that the version we get is up to us. We're looking into it! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants