Fix hwloop covg model corner issue related to irq check #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dd-baoshan <baoshan.mak@dolphin.fr>
| @@ -119,7 +119,8 @@ class uvme_rv32x_hwloop_covg # ( | |||
| bit has_pending_trap_due2_irq = 0; // has trap pending due to irq entry | |||
| bit enter_hwloop_sub = 0; | |||
| int enter_hwloop_sub_cnt = 0; | |||
| bit pending_irq = 0; | |||
| bit pending_irq = 0, pending_irq_ack = 0; | |||
There was a problem hiding this comment.
In the future, please do not declare multiple members in a single line.
There was a problem hiding this comment.
Thanks, I have updated this in this PR.
MikeOpenHWGroup
approved these changes
May 28, 2024
There was a problem hiding this comment.
Looks (mostly) good to me @dd-baoshan and it passes a local CI. In the interest of time I have approved this PR and if you need to, please go ahead and merge it. However, I have two comments. the first is "just" coding style, but the second (regarding lpend_has_pending_irq_TYPE) might be a functional issue in the general case.
Signed-off-by: dd-baoshan <baoshan.mak@dolphin.fr>
MikeOpenHWGroup
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.