Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tb issues #2437

Merged
merged 3 commits into from
May 16, 2024
Merged

Fix tb issues #2437

merged 3 commits into from
May 16, 2024

Conversation

dd-baoshan
Copy link

  1. Update bhavioral logic on collecting clk_cycle_window for b2b addr phase scnearios
  2. Fix incorrect constraint from parent after factory overidden by child class

dd-baoshan added 3 commits May 16, 2024 08:44
@dd-baoshan
Update logic to consider b2b address phase completion
d9d97e6 
Signed-off-by: dd-baoshan <baoshan.mak@dolphin.fr>
@dd-baoshan
Fix incorrect constraint from parent after factory overriden with chi…
2f81271 
…ld class

Signed-off-by: dd-baoshan <baoshan.mak@dolphin.fr>
@dd-baoshan
Fix typo
bd4eb74 
Signed-off-by: dd-baoshan <baoshan.mak@dolphin.fr>
MikeOpenHWGroup
MikeOpenHWGroup approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@MikeOpenHWGroup MikeOpenHWGroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dd-baoshan. Passes local CI on Questasim (vsim).

@MikeOpenHWGroup MikeOpenHWGroup merged commit 598b580 into openhwgroup:cv32e40p/dev May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeOpenHWGroup MikeOpenHWGroup MikeOpenHWGroup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dd-baoshan @MikeOpenHWGroup