Cv32e40p/dev #2428
Merged
Cv32e40p/dev #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd-baoshan
commented
May 13, 2024
dd-baoshan
commented
- Update correct testname
- Update behavioral logic on collecting clk_cycle_window for fpu
Signed-off-by: dd-baoshan <baoshan.mak@dolphin.fr>
Signed-off-by: dd-baoshan <baoshan.mak@dolphin.fr>
| if((clk_cycle_window == 0) && (apu_req == 1)) begin | ||
| clk_cycle_window = 1; | ||
| curr_fpu_apu_op_if = apu_op; | ||
| assert (clk_cycle_window <= MAX_FP_XACT_CYCLE); |
There was a problem hiding this comment.
In CORE-V-VERIF immediate assertions require an else clause that invokes uvm_error. After running a CI regression I have not seen this assertion fire, so in the interest of time I will approve/merge this file and create an Issue to add the else clause in a future PR.
MikeOpenHWGroup
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.